test(components): backfill advanced surface coverage

[bntvllnt]

Related to #231

Summary

• Add MDXContent coverage for markdown rendering, injected component import stripping, and markdown fallback after MDX evaluation errors.
• Add ModelSelector coverage for selected model state, provider metadata search, and selection callbacks.
• Add SocialFAB coverage for hidden state, desktop hover tracking, mobile backdrop close, and share platform launch.
• Add Slideshow coverage for portal scroll locking, completion gating, TOC navigation, and keyboard shortcuts.

Validation

• pnpm -F @vllnt/ui exec vitest run src/components/mdx-content/mdx-content.test.tsx src/components/model-selector/model-selector.test.tsx src/components/social-fab/social-fab.test.tsx src/components/slideshow/slideshow.test.tsx (4 files, 14 tests)
• pnpm -F @vllnt/ui exec eslint src/components/mdx-content/mdx-content.test.tsx src/components/model-selector/model-selector.test.tsx src/components/social-fab/social-fab.test.tsx src/components/slideshow/slideshow.test.tsx
• pnpm -F @vllnt/ui lint
• pnpm -F @vllnt/ui exec tsc --noEmit --project tsconfig.build.json
• pnpm build
• pnpm test:once (220 files, 1229 tests)
• pnpm -F @vllnt/ui check:use-client
• pnpm -F @vllnt/ui check:stories
• pnpm -F @vllnt/ui storybook:verify
• pnpm -F @vllnt/ui build-storybook
• git diff --check
• git diff --cached --check

CI status update (2026-05-19T08:46:35Z)

Current head: bed9ad6bdc89c9f19af84458e1ba160735d48516

• GitHub Actions build · sign · scan · deploy: SUCCESS (completed 2026-05-19T07:00:14Z); deploy gate recovered at the current head.
• vllnt-pilot preview/deploy status: SUCCESS (completed 2026-05-19T06:59:39Z) — https://pr-353-ui-registry.preview.vllnt.ai.
• Legacy vllnt-pilot preview check: NEUTRAL as vllnt-pilot / preview (superseded legacy) (completed 2026-05-19T06:46:42Z); retained only as superseded legacy metadata, not a blocking failure.
• Other current PR checks observed green/acceptable: Quality Gates, CodeQL, issue-link enforcement, Verify Stories, Build Storybook, Storybook Tests, Visual Regression, Scan codebase health, and language/action CodeQL analyses.
• Merge/release status: not merged; mergeStateStatus is CLEAN. Current disposition: green/manual-review-ready subject to human review; no live CI/preview blocker observed at this head.

[bntvllnt]

Review — 0 findings (0 blocking, 0 warn)

BLOCKING

• None.

WARN

• None.

VERIFIED CLEAN

• Reviewed all changed files in this PR:
  • packages/ui/src/components/mdx-content/mdx-content.test.tsx
  • packages/ui/src/components/model-selector/model-selector.test.tsx
  • packages/ui/src/components/slideshow/slideshow.test.tsx
  • packages/ui/src/components/social-fab/social-fab.test.tsx
• The added tests stay within the PR scope: advanced interaction/edge-state coverage only, no product/runtime behavior changes.
• SocialFAB coverage exercises desktop hover expansion/close, mobile backdrop close behavior, and desktop share-platform URL launching without weakening the component contract.
• CI is green on the current head, including Quality Gates, Storybook, Visual Regression, Verify Stories, react-doctor, Vercel previews, and issue-link enforcement.

VALIDATION

• Reviewed head SHA: 0c2710bb254a6ef78f46e4bbaa10e07e31cefbf5.
• Marked all 4 changed files viewed on GitHub after inspection.
• Ran pnpm install --frozen-lockfile.
• Ran pnpm --filter @vllnt/ui exec vitest run src/components/social-fab/social-fab.test.tsx — 4/4 passed.
• Ran pnpm --filter @vllnt/ui exec eslint src/components/social-fab/social-fab.test.tsx src/components/social-fab/social-fab.tsx src/components/social-fab/use-social-fab.ts — passed.
• Ran pnpm --filter @vllnt/ui test:once — 220 files / 1229 tests passed.
• Ran pnpm --filter @vllnt/ui lint — passed.

Approval is recommended, but final APPROVE is reserved for bntvllnt/manual review.

[vllnt-pilot]

Preview build failed · pr-353-ui-registry

Workflow ran but the build did not produce a runnable image. Common causes:

• lockfile drift from package.json (run pnpm install)
• missing output: standalone in next.config.mjs
• broken Dockerfile path

Check the failed build · sign · scan · deploy Action run on this PR for the exact error.

From bed9ad6.

[bntvllnt]

Review update — manual-review-ready

@bntvllnt The previous metadata-only REQUEST_CHANGES blocker is cleared for the current head.

VERIFIED LIVE

• PR: test(components): backfill advanced surface coverage #353
• Reviewed head: bed9ad6bdc89c9f19af84458e1ba160735d48516
• Head unchanged from the blocker-repair task: yes.
• mergeStateStatus: CLEAN (mergeable: MERGEABLE)
• Current checks: all current checks are success/neutral acceptable; no nonacceptable check remains.
• Deploy/preview status: recovered at the current head; preview is live at https://pr-353-ui-registry.preview.vllnt.ai.
• PR body status section now describes the current recovered CI/preview state and no longer claims a live deploy failure.

OUTCOME

• Blocking: none from the stale PR-body/deploy-status issue.
• Disposition: green/manual-review-ready, with final approval still reserved for bntvllnt.
• Scope of this update: PR body/status metadata only; no source-code changes were made or re-reviewed in this pass.

[bntvllnt]

Review — manual approval recommended

@bntvllnt I re-reviewed PR #353 at head bed9ad6bdc89c9f19af84458e1ba160735d48516 and found no blockers.

BLOCKING

None.

WARN

None.

VERIFIED CLEAN

• Current live state verified: open, non-draft, mergeStateStatus: CLEAN, mergeable: MERGEABLE, changedFiles=4, head matches the assigned SHA.
• Full changed-file coverage reviewed:
  • packages/ui/src/components/mdx-content/mdx-content.test.tsx
  • packages/ui/src/components/model-selector/model-selector.test.tsx
  • packages/ui/src/components/slideshow/slideshow.test.tsx
  • packages/ui/src/components/social-fab/social-fab.test.tsx
• Reviewed surrounding component behavior for MDX import stripping/fallback, model selector search/selection, slideshow portal state/keyboard flow/completion gating, and SocialFAB desktop/mobile interaction state.
• Rule verdicts: PASS R3 PR body freshness; PASS R5 issue link (Related to #231); PASS issue #231 test-only scope; PASS generated-artifact policy (none touched); PASS no shipped-code comments/runtime changes; PASS local targeted coverage validity.

VALIDATION

• Ran locally in the PR worktree: pnpm exec vitest run src/components/mdx-content/mdx-content.test.tsx src/components/model-selector/model-selector.test.tsx src/components/slideshow/slideshow.test.tsx src/components/social-fab/social-fab.test.tsx — 4 files, 14 tests passed.
• Live checks observed: issue-link enforcement, preview deploy, build/sign/scan/deploy, Storybook, visual regression, CodeQL, health scan, quality gates, and story verification all pass; only the superseded legacy preview check is neutral.

Verdict: no blockers. Approval is recommended, but final approval is reserved for bntvllnt per review policy.

[bntvllnt]

Review — 0 findings (0 blocking, 0 warn)

BLOCKING

• None.

WARN

• None.

VERIFIED CLEAN

• Reviewed live PR state at head bed9ad6bdc89c9f19af84458e1ba160735d48516: PR is open, non-draft, mergeable, mergeStateStatus: CLEAN, 4 changed files.
• Issue-link assessment: PR body uses Related to #231; issue #231 exists and matches the test-backfill scope (test: backfill Vitest coverage for components shipped without tests). Empty closingIssuesReferences is expected for a non-closing Related to reference and is not a blocker under the repo rule.
• Reviewed all changed files and surrounding implementations for the tested surfaces:
  • packages/ui/src/components/mdx-content/mdx-content.test.tsx
  • packages/ui/src/components/model-selector/model-selector.test.tsx
  • packages/ui/src/components/slideshow/slideshow.test.tsx
  • packages/ui/src/components/social-fab/social-fab.test.tsx
  • surrounding source: mdx-content.tsx, model-selector.tsx, slideshow.tsx, social-fab.tsx, use-social-fab.ts
• Scope is clean: only advanced-surface test files are added; no runtime/source files, generated artifacts, policy docs, or unrelated files changed.
• Test assertions line up with the component behavior they cover: MDX markdown/fallback handling, model selector filtering/selection, slideshow portal/navigation/completion flow, and SocialFAB hover/mobile/share behavior.
• Live check summary is clean/acceptable: Quality Gates, CodeQL, issue-link enforcement, Verify Stories, build/sign/scan/deploy, Storybook, visual regression, code health, and preview deploy are successful; the only neutral item is the superseded legacy preview check.

VALIDATION

• Ran: pnpm -F @vllnt/ui exec vitest run src/components/mdx-content/mdx-content.test.tsx src/components/model-selector/model-selector.test.tsx src/components/social-fab/social-fab.test.tsx src/components/slideshow/slideshow.test.tsx
• Result: 4 files passed, 14 tests passed.
• Ran: pnpm -F @vllnt/ui exec eslint src/components/mdx-content/mdx-content.test.tsx src/components/model-selector/model-selector.test.tsx src/components/social-fab/social-fab.test.tsx src/components/slideshow/slideshow.test.tsx
• Result: passed.
• Not rerun locally: full workspace build/test/storybook gates; live GitHub checks for those are green/acceptable at the reviewed head.

Verdict: clean. Manual approval is recommended, but I am leaving final APPROVE to bntvllnt per review policy.