feat: add starter templates gallery#343
Conversation
bntvllnt
added
documentation
| } | ||
|
|
||
| export function getTemplateInstallCommand(template: Template): string { | ||
| return `pnpm dlx create-vllnt-app@latest --template ${template.slug}`; |
There was a problem hiding this comment.
This helper now publishes --template ${template.slug} to the template page, llms surfaces, and template READMEs/metadata, but several of the new gallery slugs are not accepted by the current scaffolder. create-vllnt-app supports presets/aliases such as saas, dashboard, docs, web, mobile, and fullstack; it does not support next-starter, ai-chat, or docs-site, and npm view create-vllnt-app@latest currently returns E404. That makes the primary install command on the new public template pages fail for users/agents.
| "ai-source-citation", | ||
| "ai-streaming-text", | ||
| "ai-tool-call-display", | ||
| "conversation-thread", |
There was a problem hiding this comment.
conversation-thread is not in apps/registry/registry.json (nor anywhere else in apps/registry), but the template detail page renders each component as /components/${component}. This publishes a dead /components/conversation-thread link from /templates/ai-chat; please either add the component to the registry or replace this slug with the existing component that represents the conversation surface.
|
Review outcome: REQUEST_CHANGES (blocking) I found two blockers in the template gallery as currently shipped:
Validation performed:
Recommended fix: either align the UI gallery slugs/install commands with actual create-vllnt-app presets ( |
|
Review outcome: BLOCKED (GitHub would not let this account submit REQUEST_CHANGES on its own PR) The code-specific issues from my earlier pass appear addressed in this head: the template pages no longer publish unsupported create-vllnt-app install commands, and the AI Chat component list now only links registry-backed component slugs. I also rechecked the template manifests against the registry component slugs and found no failures. Remaining blockers before this can merge:
Validation I performed:
|
bntvllnt
left a comment
bntvllnt
left a comment
There was a problem hiding this comment.
@bntvllnt Review verdict: REQUEST_CHANGES recommended — template source blocker
Head reviewed: bf124a6ad092007b363bd8ac7526ba6ef0a81a6f
BLOCKING
- The new templates surface advertises copyable starter-template source and “GitHub source” links, but each
templates/<slug>/directory contains onlyREADME.md,template.json, andscreenshots/preview.svg. There is no actual starter app/source for users to copy. The public page and READMEs therefore promise source that the PR does not ship.
WARNING
demoUrlpoints back to the template detail page for each template while the UI labels it “Live demo”. If intentional, consider relabeling to avoid implying a runnable demo.
STATUS
- GitHub Actions/code checks are green and
Vercel – storybookis SUCCESS. Vercel – ui.vllnt.ai: FAILUREis eligible for the PM stale-Vercel reviewer-triage waiver only; it is not merge/release approval.- Validation gap: I did not rerun full local workspace gates; this review used the live GitHub status rollup plus changed-file inspection.
|
|
||
| <section className="mt-10"> | ||
| <h2 className="text-2xl font-semibold">Source</h2> | ||
| <p className="mt-4 text-sm text-muted-foreground"> |
There was a problem hiding this comment.
Blocking: the page tells users to copy/adapt files from the template source, but each templates/<slug>/ directory only contains README/template metadata/screenshot files. Either ship actual starter source or change the public copy/links so they don't promise copyable template source.
|
Preview ready · pr-343-ui-registry
Inspect
|
- Add meaningful alt text to template screenshot images in both the
gallery page and the detail page: `{title} template screenshot`
- Remove the "Live demo" CTA button from the detail page sidebar; all
demoUrl values pointed at the registry's own template detail page
(self-referential loop) rather than a live hosted demo. Dropping the
button is the safer option until real demo deployments exist.
The demoUrl field in lib/templates.ts is left in place so it can be
wired up to actual demos in a follow-up without a data-model change.
- Remove installUrl from softwareApplicationLd JSON-LD output; no
install endpoint exists, so the field was misleading schema.org markup.
bntvllnt
left a comment
bntvllnt
left a comment
There was a problem hiding this comment.
Review — 2 blocking findings (comment-only; GitHub does not allow this account to request changes on its own PR)
BLOCKING
- C1 — Template source/demos are advertised as copyable starter kits, but the target folders only contain README, template.json, and preview SVG. The new detail pages and llms-full reference tell users/agents to copy/adapt template source files that do not exist.
- C2 — Machine-readable/docs surfaces still expose self-referential
DemoURLs even though the PR explicitly removed the UI demo CTA because those URLs are only the template detail pages.
VERIFIED CLEAN
- Reviewed PR #343 at head
76f8517d793d4186175b3fbf7e84e569ed03f280; live checks remain 9/9 successful. - Issue link is present (
closes #259). - Gallery/detail routes, metadata, sitemap additions, header/sidebar/home navigation, JSON-LD installUrl removal, and image alt text were inspected.
- All 32 changed files were covered, including template READMEs/manifests and screenshots.
VALIDATION
- Ran locally:
git diff --check origin/main...HEAD;pnpm -F @vllnt/ui-registry exec tsc --noEmit --project tsconfig.json;npx --yes react-doctor . --diff origin/main --annotations --fail-on error --offline;pnpm -F @vllnt/ui lint;pnpm -F @vllnt/ui exec tsc --noEmit --project tsconfig.build.json;pnpm build;pnpm test:once. - Result: all exited 0. React Doctor emitted existing warnings; test run passed 216 files / 1215 tests with the known jsdom/share-dialog/interactive-timeline warnings.
Please either add real copyable template source/app files for each starter kit, or revise the page/README/llms copy so these are clearly inspiration/metadata templates only and remove/rename the self-referential demo fields from user/agent-facing outputs.
| <section className="mt-10"> | ||
| <h2 className="text-2xl font-semibold">Source</h2> | ||
| <p className="mt-4 text-sm text-muted-foreground"> | ||
| This template is available as source in the VLLNT UI |
There was a problem hiding this comment.
This source promise is not true at this head. Each templates/<slug> folder only contains README.md, template.json, and screenshots/preview.svg; there are no app/page/component files to copy or adapt. That makes the new detail pages send users to a GitHub source folder that cannot actually function as a starter kit. Please either add the promised copyable source files for all five templates or change this wording/CTA to describe these as metadata/inspiration templates only.
| lines.push(""); | ||
| lines.push(`- Slug: \`${template.slug}\``); | ||
| lines.push(`- Page: ${SITE_URL}${getTemplatePath(template)}`); | ||
| lines.push(`- Demo: ${template.demoUrl}`); |
There was a problem hiding this comment.
The PR body says the Live demo CTA was removed because demoUrl points back to the same template detail page, but /llms-full.txt still emits that self-referential value as Demo. This is especially risky because agents will treat the full LLM reference as structured truth and may believe a real runnable demo exists. Please remove this line until a real demo exists, or rename it to Page/Registry page and avoid duplicating the already-emitted page URL.
1 participant
Summary
/templatesand/templates/[slug]routes for five starter kits: next-starter, dashboard, saas, ai-chat, and docs-site.templates/<slug>/, SoftwareApplication JSON-LD, sitemap entries, and llms.txt/llms-full.txt template sections.alt=""on template screenshot images (detail page + gallery) — now"{title} template screenshot".demoUrlvalues were self-referential (pointed at the registry's own template detail page). The field is preserved in the data model for future wiring. The "GitHub source" button remains.Validation
apps/registryortemplatessource matches forcreate-vllnt-app,--template,installUrl,Live demo, or template install commands.Notes: templates are presented as source to copy/adapt until a supported template CLI exists.
pnpm buildstill emits the known Next.js multiple-lockfile worktree warning.pnpm test:oncestill emits existing jsdom navigation, ShareDialog description, and InteractiveTimeline duplicate-key warnings while passing all tests.Closes #259