fix(react-doctor): rename generic handlers#339
Open
bntvllnt wants to merge 3 commits into
Open
Conversation
|
Preview ready · pr-339-ui-registry
Inspect
|
bntvllnt
commented
May 19, 2026
Collaborator
Author
bntvllnt
left a comment
There was a problem hiding this comment.
Review — clean / manual approval recommended
BLOCKING
None.
WARN
None.
VERIFIED CLEAN
- Reviewed current head
4f4cc4560efa062af78680293c2f58cc3e23a59cfor PR #339 (fix/issue-276-handler-names). - Reviewed all 39 changed files: 18 registry shims, 20 package component files, and 1 package test file.
- The diff is a narrow
react-doctor/no-generic-handler-namescleanup: generic local handler definitions were renamed to action-oriented names while DOM event prop names and external callback props stayed intact. - Behavior is preserved: consumer
onClickordering,event.defaultPreventedguards, callback payloads, and event propagation behavior remain equivalent. - Registry mirrors match the package-side rename intent for the included components.
- PR metadata is current: it closes #276, references #279, and its file count / validation claims match the live diff and check state.
- Post-review head drift from
8a11c6bb4a7c70fefbd3ad0ce5f0511f0704053fto this head is non-product drift only: the PR file list is unchanged; the branch only absorbed main-side CI/deploy metadata (.github/workflows/build.yml,Dockerfile, manifests/lockfile) outside the PR delta.
VALIDATION
- Live GitHub checks re-fetched before publication: 13 visible checks, all
passorskipping; no failures. - Local targeted rule gate run from the review worktree:
pnpm doctor:json; exit 0.react-doctor/no-generic-handler-namesdiagnostics count is 0. - Local grep spot-check found only
handleSubmitinknowledge-check, which is not flagged by react-doctor and is semantically submit-specific. - Viewed-state coverage: marked all 39 changed files viewed successfully.
- Not rerun locally in this review pass: full
pnpm -F @vllnt/ui lint,tsc,pnpm build,pnpm test:once; relied on live green GitHub checks plus PR-body preserved evidence for those full gates.
Verdict: approval recommended, but final approval remains reserved for bntvllnt/manual review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
react-doctor/no-generic-handler-nameshandler definitions inpackages/uito action-oriented names while preserving DOM event prop names./r/*sources mirror the package changes.onClickordering,defaultPreventedguards, callback payloads, and event propagation behavior.Closes #276
Related to #279
Validation
pnpm doctor:json && jq '[.diagnostics[] | select(.rule == "no-generic-handler-names")] | length' .react-doctor.jsonPASS (0)pnpm -F @vllnt/ui exec eslint <changed package files>PASSpnpm -F @vllnt/ui lintPASSpnpm -F @vllnt/ui exec tsc --noEmit --project tsconfig.build.jsonPASSpnpm buildPASSpnpm test:oncePASS (216 files, 1215 tests)git diff --checkPASSNotes:
pnpm buildemitted the existing Next.js multiple-lockfile warning for this nested worktree. Vitest emitted existing jsdom navigation, duplicate-key, and Radix dialog-description warnings while passing.Design Deviations
None.