Skip to content

fix(react-doctor): rename generic handlers#339

Open
bntvllnt wants to merge 3 commits into
mainfrom
fix/issue-276-handler-names
Open

fix(react-doctor): rename generic handlers#339
bntvllnt wants to merge 3 commits into
mainfrom
fix/issue-276-handler-names

Conversation

@bntvllnt
Copy link
Copy Markdown
Collaborator

Summary

  • Renamed all react-doctor/no-generic-handler-names handler definitions in packages/ui to action-oriented names while preserving DOM event prop names.
  • Regenerated the registry component shims so the public /r/* sources mirror the package changes.
  • Kept behavior unchanged, including consumer onClick ordering, defaultPrevented guards, callback payloads, and event propagation behavior.

Closes #276
Related to #279

Validation

  • pnpm doctor:json && jq '[.diagnostics[] | select(.rule == "no-generic-handler-names")] | length' .react-doctor.json PASS (0)
  • pnpm -F @vllnt/ui exec eslint <changed package files> PASS
  • pnpm -F @vllnt/ui lint PASS
  • pnpm -F @vllnt/ui exec tsc --noEmit --project tsconfig.build.json PASS
  • pnpm build PASS
  • pnpm test:once PASS (216 files, 1215 tests)
  • git diff --check PASS

Notes: pnpm build emitted the existing Next.js multiple-lockfile warning for this nested worktree. Vitest emitted existing jsdom navigation, duplicate-key, and Radix dialog-description warnings while passing.

Design Deviations

None.

@bntvllnt bntvllnt self-assigned this May 12, 2026
@bntvllnt bntvllnt added react-doctor Reported by react-doctor (codebase health) tech-debt Refactoring or cleanup dx Developer experience labels May 12, 2026
bntvllnt

This comment was marked as outdated.

@vllnt-pilot vllnt-pilot Bot had a problem deploying to Preview · pr-339-storybook May 18, 2026 17:14 Failure
@vllnt-pilot
Copy link
Copy Markdown

vllnt-pilot Bot commented May 18, 2026

Preview ready · pr-339-ui-registry

Service Status Preview
ui-registry Ready https://pr-339-ui-registry.preview.vllnt.ai
Inspect
  • Deployed to vllnt-cluster from 4f4cc45
  • Reply with /clean to destroy this preview now

@vllnt vllnt deleted a comment from vllnt-pilot Bot May 18, 2026
@vllnt vllnt deleted a comment from vercel Bot May 18, 2026
Copy link
Copy Markdown
Collaborator Author

@bntvllnt bntvllnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review — clean / manual approval recommended

BLOCKING

None.

WARN

None.

VERIFIED CLEAN

  • Reviewed current head 4f4cc4560efa062af78680293c2f58cc3e23a59c for PR #339 (fix/issue-276-handler-names).
  • Reviewed all 39 changed files: 18 registry shims, 20 package component files, and 1 package test file.
  • The diff is a narrow react-doctor/no-generic-handler-names cleanup: generic local handler definitions were renamed to action-oriented names while DOM event prop names and external callback props stayed intact.
  • Behavior is preserved: consumer onClick ordering, event.defaultPrevented guards, callback payloads, and event propagation behavior remain equivalent.
  • Registry mirrors match the package-side rename intent for the included components.
  • PR metadata is current: it closes #276, references #279, and its file count / validation claims match the live diff and check state.
  • Post-review head drift from 8a11c6bb4a7c70fefbd3ad0ce5f0511f0704053f to this head is non-product drift only: the PR file list is unchanged; the branch only absorbed main-side CI/deploy metadata (.github/workflows/build.yml, Dockerfile, manifests/lockfile) outside the PR delta.

VALIDATION

  • Live GitHub checks re-fetched before publication: 13 visible checks, all pass or skipping; no failures.
  • Local targeted rule gate run from the review worktree: pnpm doctor:json; exit 0. react-doctor/no-generic-handler-names diagnostics count is 0.
  • Local grep spot-check found only handleSubmit in knowledge-check, which is not flagged by react-doctor and is semantically submit-specific.
  • Viewed-state coverage: marked all 39 changed files viewed successfully.
  • Not rerun locally in this review pass: full pnpm -F @vllnt/ui lint, tsc, pnpm build, pnpm test:once; relied on live green GitHub checks plus PR-body preserved evidence for those full gates.

Verdict: approval recommended, but final approval remains reserved for bntvllnt/manual review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dx Developer experience react-doctor Reported by react-doctor (codebase health) tech-debt Refactoring or cleanup

Projects

None yet

Development

Successfully merging this pull request may close these issues.

react-doctor: rename generic handler names — handleClick/handleChange → action verbs (51 warnings)

1 participant