🔧 Restore Node after SDK release notes#289
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
Robdel12
force-pushed
the
rd/sdk-release-node-restore
branch
from
d1c3042 to
db0da49
Compare
This comment has been minimized.
This comment has been minimized.
Robdel12
force-pushed
the
rd/sdk-release-node-restore
branch
from
db0da49 to
38b71c8
Compare
Robdel12
changed the title
This comment has been minimized.
This comment has been minimized.
Reset Node.js to the release runtime after Codex changelog generation in the Node-based SDK release workflows. This keeps the workflows single-job and fixes pnpm/npm commands inheriting Codex action's internal Node 20 setup.
Robdel12
force-pushed
the
rd/sdk-release-node-restore
branch
from
38b71c8 to
f109f8d
Compare
Robdel12
changed the title
Vizzly - Visual Test ResultsCLI Reporter - Waiting for buildNo builds received yet for this pull request.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The static-site SDK release failed before tests/publish because the Codex changelog action switches the active job runtime back to Node 20. Our SDK release workflows install pnpm 11, which requires Node 22+, so the next pnpm command crashed before the package could test or publish.
The warning points at
actions/setup-node@49933...because that setup-node call lives insideopenai/codex-action, not in these workflows. This PR fixes the breakage by setting the release job runtime back to our supported Node version immediately after Codex runs.What changed
actions/setup-node@v6step in the Storybook, Static Site, Vitest, and Ember SDK release workflows.pnpm install, tests, build, pack, and publish.Verification
git diff --check HEAD^ HEAD