Skip to content

Conversation

@xuchang-vivo
Copy link
Contributor

No description provided.

@xuchang-vivo xuchang-vivo reopened this Nov 25, 2025
@xuchang-vivo xuchang-vivo marked this pull request as draft November 25, 2025 02:46
@xuchang-vivo
Copy link
Contributor Author

@xuchang-vivo xuchang-vivo marked this pull request as ready for review December 5, 2025 09:05
@github-actions
Copy link

github-actions bot commented Dec 5, 2025

@github-actions
Copy link

github-actions bot commented Dec 5, 2025

❌ Job failed. Failed jobs: check_format (failure), build_and_check_boards (failure), see https://github.com/vivoblueos/kernel/actions/runs/19958036843.

@xuchang-vivo
Copy link
Contributor Author

@github-actions
Copy link

github-actions bot commented Dec 5, 2025

@github-actions
Copy link

github-actions bot commented Dec 5, 2025

✅ All jobs completed successfully, see https://github.com/vivoblueos/kernel/actions/runs/19958506531.

@xuchang-vivo
Copy link
Contributor Author

@github-actions
Copy link

github-actions bot commented Dec 5, 2025

@github-actions
Copy link

github-actions bot commented Dec 5, 2025

✅ All jobs completed successfully, see https://github.com/vivoblueos/kernel/actions/runs/19958987260.

@xuchang-vivo
Copy link
Contributor Author

@github-actions
Copy link

github-actions bot commented Dec 5, 2025

@github-actions
Copy link

github-actions bot commented Dec 5, 2025

✅ All jobs completed successfully, see https://github.com/vivoblueos/kernel/actions/runs/19959313447.

Copy link
Contributor

@lawkai-vivo lawkai-vivo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please include runnable tests on at least one qemu platform.

@xuchang-vivo
Copy link
Contributor Author

Please include runnable tests on at least one qemu platform.

Writing an I2C test on QEMU isn't that straightforward, because I2C is a master–slave protocol: besides the host controller you also need a slave device to establish communication. To test an I2C driver on QEMU you therefore need to emulate an I2C slave device in QEMU.

@xuchang-vivo
Copy link
Contributor Author

@github-actions
Copy link

@github-actions
Copy link

❌ Job failed. Failed jobs: setup (failure). Skipped jobs: check_format (skipped), check_license (skipped), build_host (skipped), build_and_check_boards (skipped), see https://github.com/vivoblueos/kernel/actions/runs/20356945916.

@xuchang-vivo
Copy link
Contributor Author

@github-actions
Copy link

@github-actions
Copy link

❌ Job failed. Failed jobs: setup (failure). Skipped jobs: check_format (skipped), check_license (skipped), build_host (skipped), build_and_check_boards (skipped), see https://github.com/vivoblueos/kernel/actions/runs/20357174959.

@xuchang-vivo
Copy link
Contributor Author

@github-actions
Copy link

@github-actions
Copy link

✅ All jobs completed successfully, see https://github.com/vivoblueos/kernel/actions/runs/20357219455.

@xuchang-vivo
Copy link
Contributor Author

Please include runnable tests on at least one qemu platform.

Another way to test the I2C & sensor drivers is to use Renode together with the Robot test framework.

See: https://renode.readthedocs.io/en/latest/basic/sensors.html
https://renode.readthedocs.io/en/latest/introduction/testing.html
https://github.com/topics/robot-test

@xuchang-vivo
Copy link
Contributor Author

@github-actions
Copy link

@xuchang-vivo
Copy link
Contributor Author

@github-actions
Copy link

@github-actions
Copy link

✅ All jobs completed successfully, see https://github.com/vivoblueos/kernel/actions/runs/20591419535.

@github-actions
Copy link

✅ All jobs completed successfully, see https://github.com/vivoblueos/kernel/actions/runs/20591458461.

@lawkai-vivo
Copy link
Contributor

@github-actions
Copy link

@github-actions
Copy link

✅ All jobs completed successfully, see https://github.com/vivoblueos/kernel/actions/runs/20592791813.

@lawkai-vivo lawkai-vivo merged commit 4da78d2 into vivoblueos:main Dec 30, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants