[Fix] Resolves Domain Dialog Issues#1055
Merged
saeedvaziry merged 3 commits intovitodeploy:3.xfrom Mar 18, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces improvements to the domain management workflow, focusing on optimizing how available domains are fetched and refreshed from DNS providers. The main changes include adding caching for domain retrieval, introducing a backend refresh endpoint, and updating the frontend to support domain list refreshes and improved user experience.
Backend enhancements:
GetAvailableDomainsthat retrieves available domains from a DNS provider, caches the results, and filters out domains already added, improving efficiency and reducing unnecessary API calls.DomainControllerto use theGetAvailableDomainsaction for fetching available domains, and added a newrefreshDomainsendpoint to force a refresh and bypass the cache. [1] [2]Frontend improvements:
add-domain.tsxcomponent to support refreshing the domain list via the new backend endpoint, including a refresh button with loading state and improved form reset logic when opening the dialog. [1] [2] [3] [4]RefreshCwicon for the refresh button in the domain selection UI.Unit Tests:
Resolves #1042