Ported inputs ability
#8
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yjaaidi
approved these changes
Dec 6, 2025
yjaaidi
left a comment
yjaaidi
left a comment
There was a problem hiding this comment.
LGTM.
Thanks for this.
Mostly nitpick that we can fix pre or post-merge.
| @@ -1,10 +1,13 @@ | |||
| import { getTestBed } from "@angular/core/testing"; | |||
There was a problem hiding this comment.
Why not replace this whole file with a call to Analog's setupTestBed?
It has all the typical setup to work with or without isolation etc...
https://github.com/analogjs/analog/blob/0b255202253a418f88717c6e178f0bb179725e3c/packages/vitest-angular/setup-testbed.ts#L22?
| import { TestBed } from "@angular/core/testing"; | ||
| import { beforeEach } from "vitest"; | ||
|
|
||
| setupAngularTestEnvironment(); |
There was a problem hiding this comment.
|
|
||
| export default defineConfig({ | ||
| plugins: [ | ||
| angular({ tsconfig: './tsconfig.json' }) as unknown as PluginOption, |
There was a problem hiding this comment.
Didn't try this locally but this as unknown as PluginOption seems to be related to multiple vite versions incompatibility. Can't we fix that instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implementation has been ported from https://github.com/yjaaidi/vitest-browser-angular to enable inputs passing on render.
CREDIT: @yjaaidi