-
Notifications
You must be signed in to change notification settings - Fork 2
Implement zoneless configuration #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Implement zoneless configuration #6
Conversation
|
Thanks for the PR @MRinaldi9 ! Added a few comments |
…on for zoneless testing setup
|
i had changed the tsconfig because in v4 vitest there is no need to set the types for the providers and i added the globals so the tests have less "imports code". |
|
Thanks for the fixes @MRinaldi9 ! @yjaaidi wanna review before we merge? |
|
Hi @MRinaldi9, first of all thank you for the contribution. The thing is that the whole TestBed setup (including zoneful/zoneless setup) is already performed by Angular's We still have to discuss this with @shairez but I think that we should reduce the surface of this package to providing a What do you think Shai? |
|
Thanks @yjaaidi for the review The reason I originally added this file was because there was a specific order in which the files it is importing - You need to load the compiler before the setup-zone, or else it fails. It took me some time to figure this out so I didn't want others to waste their time on this, so that's why I've added it originally. I think there is value in providing it as a utility which is required for the vitest browser mode tests to work with the analog vite plugin. But maybe it's indeed not relevant for angular/cli tests maybe we prefix it with what are the downsides you see for keeping it? |
#5 Closing this issue