Add i18n table links#2560
Draft
hupf wants to merge 3 commits into
Draft
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes these issues:
https://gitlab.lindas.admin.ch/bafu/bafu-visualize/visualization-tool/-/issues/106
https://gitlab.lindas.admin.ch/bafu/bafu-visualize/visualize/-/issues/765
This PR extends the links attributes of table diagrams such that a language-specific base URL can be defined (currently it is only possible to define a single base URL across all languages). As implemented, there is no fallback mechanism between languages; if a language has no base URL defined, the column won't be linked. Previous chart configs with a base URL defined, will be migrated, such that this URL will be used for each language.
How to test