Skip to content

fix: sanitize urls from external sources #2556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mburri wants to merge 2 commits into
base: main
Choose a base branch
from
+8 −7
Open

fix: sanitize urls from external sources #2556

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7793cb6
fix: sanitize urls from external sources
mburri May 7, 2026
c601a29
chore: pin @braintree/sanitize-url to 7.1.2
mburri May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ You can also check the
- Refactoring
- Incorporate the Swiss-Federal-CI library into this repository.
- Fixes
- Sanitize urls for links in tables
- Sanitize URLs from external sources
- Improve CSP header configuration
- Maintenance
- Remove Google Analytics integration (it is no longer in use)
Expand Down
3 changes: 2 additions & 1 deletion app/components/dataset-metadata.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import { sanitizeUrl } from "@braintree/sanitize-url";
import { Trans } from "@lingui/macro";
import {
Box,
Expand Down Expand Up @@ -104,7 +105,7 @@ export const DatasetMetadata = ({
<DatasetMetadataBody sx={{ mt: "1px" }}>
{cube.landingPage ? (
<DatasetMetadataLink
href={cube.landingPage}
href={sanitizeUrl(cube.landingPage)}
external
label={
<Trans id="dataset.metadata.learnmore">
Expand Down
2 changes: 1 addition & 1 deletion app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"@apollo/client": "^3.3.20",
"@apollo/server-plugin-landing-page-graphql-playground": "^4.0.1",
"@babel/standalone": "^7.11.6",
"@braintree/sanitize-url": "^7.1.1",
"@braintree/sanitize-url": "7.1.2",
"@deck.gl/core": "^9.1.2",
"@deck.gl/extensions": "^9.1.2",
"@deck.gl/geo-layers": "^9.1.2",
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2506,10 +2506,10 @@
dependencies:
buffer "^6.0.3"

"@braintree/sanitize-url@^7.1.1":
version "7.1.1"
resolved "https://registry.yarnpkg.com/@braintree/sanitize-url/-/sanitize-url-7.1.1.tgz#15e19737d946559289b915e5dad3b4c28407735e"
integrity sha512-i1L7noDNxtFyL5DmZafWy1wRVhGehQmzZaz1HiN5e7iylJMSZR7ekOV7NsIqa5qBldlLrsKv4HbgFUVlQrz8Mw==
"@braintree/sanitize-url@7.1.2":
version "7.1.2"
resolved "https://registry.yarnpkg.com/@braintree/sanitize-url/-/sanitize-url-7.1.2.tgz#ca2035b0fefe956a8676ff0c69af73e605fcd81f"
integrity sha512-jigsZK+sMF/cuiB7sERuo9V7N9jx+dhmHHnQyDSVdpZwVutaBu7WvNYqMDLSgFgfB30n452TP3vjDAvFC973mA==

"@catalog/core@^4.0.1-canary.2":
version "4.0.1-canary.2"
Expand Down
Loading