Skip to content

Wizard optimizations, Sidebar and Filter Addition#59

Open
Thorfinson wants to merge 20 commits into
mainfrom
wizard_optimizations
Open

Wizard optimizations, Sidebar and Filter Addition#59
Thorfinson wants to merge 20 commits into
mainfrom
wizard_optimizations

Conversation

@Thorfinson
Copy link
Copy Markdown
Member

@Thorfinson Thorfinson commented Feb 16, 2026

  • Added the index db local storage of datasets. Can be deleted with icon next to it.
  • wizard redesign, tables unified, new layouts for Step 3 and Step 4, Added Step 5 Review
  • Fixed sidebar to the right, added Accordeon Style Menu for Style, Encoding and Filtering
  • Reworked filtering a bit. Added selection filter and filter chips, so they can be deleted per column
  • Cleanup and DRYness refactoring
  • Refactor and Decompose GlyphCanvasComponent and DataProviderService as Well as Add Glyph Types
  • Add Linting and Fix Linting Errors and Warnings
  • Add first tests

@Thorfinson Thorfinson requested a review from dkammer February 16, 2026 19:12
@Thorfinson Thorfinson self-assigned this Feb 16, 2026
@dkammer
Copy link
Copy Markdown
Member

dkammer commented Feb 27, 2026

Minor style fixes:

Fix Top bar width

The fit all button should no longer needed to be squashed (label text is wrapped), after there is now space with the legends and filters no longer to the right side.

image

Glyph legend positioning in sidebar

I believe the example glyph / glyph legend should still be on the very top with the options underneath

image

Make sidebar buttons effective

The buttons should actually only open individual panes with their corresponding options, otherwise I think the sidebar is getting too crowded?!

image

I guess that "Encoding" and "Style" could be in one sidebar menu button option (or not if there is more styling to be done in the Style section).

Bring screenshot option back

This has been a feature request from collaborators for them in order to use high quality images of their data sets in papers, documentation etc.

image

(can be placed elsewhere)

Position menu button styling

The styling of the button for changing the positioning is kinda off...

image

Canvas menu bar height and styling

I believe the canvas menu bar can be made almost half its current height. I still think having it disappear or diminished on not active canvases is a nice UI feature. Only the selected positioning algorithm (and maybe the timestamp) should be visible to the left in inactive canvases, but without the grey background, possibly hovering text with a full white background only underneath the text. I think we do not need the info on the glyph type anymore there?

image

Items information in sidebar

Can we get all of this on one line, without wrapping the blue button thingy?

image

canvas header restyle, magic lens visibility fix

- menubar: stop Fit all from wrapping; add Screenshot button
- sidebar: glyph preview moved to top of Encoding; strip buttons
  now open one pane at a time; item count + filter chips on one row
- canvas header: half-height, transparent when inactive, only Pos
  pill visible; drop redundant Glyph info; softer Pos button styling
- magic lens: stop hiding glyphs under the cursor indicator
- update package versions
@Thorfinson
Copy link
Copy Markdown
Member Author

Added Feedback from @dkammer

@dkammer
Copy link
Copy Markdown
Member

dkammer commented May 22, 2026

  • When activating a canvas (clicking on it to reveal its menu bar), there is a small jump inside the canvas, meaning all items drop a few pixels down. Possibly due to the added menu bar borders or similar. An issue with box-sizing or something?
  • Even if the canvas menu bar is not shown, items are hidden at the top beneath a white background of this menu bar
  • Solution: Show canvas menu bar permanently
  • I am still unsure about how the side menu buttons should work: Currently they open one and the same side bar, with specific accordion sections opened; that is somehow useful because you can navigate to anywhere you want, but is counter intuitive to the usual workings (e.g. VS Code) of the side buttons, which open individual sidebar functions or areas -- Right side bar should behave like VS Code :-)
  • I am still not happy with the look and feel of the "position button" in the canvas menu bar:
image image
  • Fit to screen button in canvas should be the old one:
image
  • The current arrow looks like maximize canvas / close other canvases can stay with this functionality
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants