fix: remove stale @ts-ignore for localIdeographFontFamily across all map modules#2587
Open
subodhbhyri wants to merge 1 commit intovisgl:masterfrom
Open
fix: remove stale @ts-ignore for localIdeographFontFamily across all map modules#2587subodhbhyri wants to merge 1 commit intovisgl:masterfrom
subodhbhyri wants to merge 1 commit intovisgl:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Three files contained a
// @ts-ignore Mapbox specific propcomment above thelocalIdeographFontFamilyassignment in_updateStyle:modules/react-maplibre/src/maplibre/maplibre.tsmodules/react-mapbox/src/mapbox/mapbox.tsmodules/main/src/mapbox-legacy/mapbox/mapbox.tsThe comment was misleading and the
@ts-ignorewas unnecessary:localIdeographFontFamilyis fully present inmaplibre-glv5'sMapOptionsandStyleOptionstypeslocalIdeographFontFamilyis present inmapbox-glv3'sMapOptionstype (line 15141)mapbox-glv1 ships no.d.tsfiles at all, so the propis valid at runtime regardless
In all three cases, TypeScript 4.9+
in-operator narrowing makes the@ts-ignoreunnecessary. Insideif ('localIdeographFontFamily' in nextProps),TypeScript widens
nextPropsto...Props & Record<'localIdeographFontFamily', unknown>,making the property access legal. Since
optionsis typedany, assigningunknown → anyis permitted without suppression.Fixes #2537
Changes
@ts-ignorefrom all three filesNotes
localIdeographFontFamilyalready reaches the MapLibre/Mapbox constructorcorrectly via the
...propsspread in_initialize()— no runtime behavioris changed by this PR.