Fix registry path and update virtiofsd command syntax #22
Conversation
elizashurov
commented
Jan 18, 2026
elizashurov
commented
- Change registry path from HKLM\Software\virtiofs to HKLM\Software\VirtIO-FS
- Replace -o source= with --shared-dir
- Change registry path from HKLM\Software\virtiofs to HKLM\Software\VirtIO-FS - Replace -o source= with --shared-dir Signed-off-by: Elizabeth Ashurov <eashurov@redhat.com>
Summary of ChangesHello @elizashurov, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the documentation for VirtIO-FS, ensuring that configuration instructions are accurate and up-to-date. It addresses a specific registry path for Windows service settings and updates the command-line syntax for the virtiofsd daemon, improving clarity and correctness for users setting up shared file systems. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly updates the virtiofsd command syntax from -o source= to --shared-dir and changes the Windows registry path to HKLM\Software\VirtIO-FS in the documentation files. The changes align with the PR's goal.
I've added a couple of suggestions to improve naming consistency on the changed lines.
Additionally, I noticed that Knowledge-Base/Virtiofs:-Shared-file-system.md seems to be a partial duplicate of Knowledge-Base/Virtiofs-qs.md. To improve maintainability and prevent future inconsistencies, you might consider consolidating them. For instance, Virtiofs:-Shared-file-system.md contains a small error in a command example (line 170) that is correct in Virtiofs-qs.md, highlighting the risk of maintaining duplicate content.
| ``` | ||
| Since command-line arguments can't be assigned to Windows service permanently, virtiofs can parse them from the registry. When command-line arguments are absent the service looks up for the following parameters under `HKLM\Software\virtiofs`: | ||
| Since command-line arguments can't be assigned to Windows service permanently, virtiofs can parse them from the registry. When command-line arguments are absent the service looks up for the following parameters under `HKLM\Software\VirtIO-FS`: |
There was a problem hiding this comment.
For consistency with the new registry path VirtIO-FS, consider updating virtiofs to VirtIO-FS in this sentence. This will improve readability and align the document with the naming convention being adopted.
| Since command-line arguments can't be assigned to Windows service permanently, virtiofs can parse them from the registry. When command-line arguments are absent the service looks up for the following parameters under `HKLM\Software\VirtIO-FS`: | |
| Since command-line arguments can't be assigned to Windows service permanently, VirtIO-FS can parse them from the registry. When command-line arguments are absent the service looks up for the following parameters under `HKLM\Software\VirtIO-FS`: |
| ``` | ||
|
|
||
| Since command-line arguments can't be assigned to Windows service permanently, virtiofs can parse them from the registry. When command-line arguments are absent the service looks up for the following parameters under `HKLM\Software\virtiofs`: | ||
| Since command-line arguments can't be assigned to Windows service permanently, virtiofs can parse them from the registry. When command-line arguments are absent the service looks up for the following parameters under `HKLM\Software\VirtIO-FS`: |
There was a problem hiding this comment.
For consistency with the new registry path VirtIO-FS, consider updating virtiofs to VirtIO-FS in this sentence. This will improve readability and align the document with the naming convention being adopted.
| Since command-line arguments can't be assigned to Windows service permanently, virtiofs can parse them from the registry. When command-line arguments are absent the service looks up for the following parameters under `HKLM\Software\VirtIO-FS`: | |
| Since command-line arguments can't be assigned to Windows service permanently, VirtIO-FS can parse them from the registry. When command-line arguments are absent the service looks up for the following parameters under `HKLM\Software\VirtIO-FS`: |
1 participant
