Placeholder as the Default Homeserver#101
Open
simurgh9 wants to merge 2 commits into
Open
Conversation
Comment on lines
+132
to
+134
| default: | ||
| Logger.matrixClient.error("\(showError.localizedDescription)") | ||
| return "Something went wrong!" |
Owner
There was a problem hiding this comment.
I don't like this solution to make the errors prettier, since it default case catches too many errors under the unuseful "Something went wrong!" error. I'd rather have a harder to read error message than an opaque generic error like this.
For instance if you attempt to sign in and the username and password is incorrect this error is presented, the old error message was a bit harder to read, but it did say that the credentials were wrong.
Ideally, we should implement a nicely formatted error for all cases, but a simpler halfway solution is to return the original showError.localizedDescription if something goes wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #68.