Skip to content

Automated follow-up to PR #123 #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vikram-dagger wants to merge 1 commit into
base: vikram-dagger-patch-5
Choose a base branch
from
Open

Automated follow-up to PR #123 #124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ class BookIn(BaseModel):

title: str
author: str
publisher: str


class BookOut(BaseModel):
Expand All @@ -35,4 +36,4 @@ class BookOut(BaseModel):
title: str
author: str

model_config = ConfigDict(from_attributes=True)
model_config = ConfigDict(from_attributes=True)
3 changes: 2 additions & 1 deletion repositories.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

# Create a new book
def create_book(db: Session, book: models.BookIn):
db_book = models.Book(title=book.title, author=book.author)
db_book = models.Book(title=book.title, author=book.author, publisher=book.publisher)
db.add(db_book)
db.commit()
db.refresh(db_book)
Expand All @@ -27,6 +27,7 @@ def update_book(db: Session, book_id: int, book: models.BookIn):
if db_book:
db_book.title = book.title
db_book.author = book.author
db_book.publisher = book.publisher
db.commit()
db.refresh(db_book)
return db_book
Expand Down
8 changes: 4 additions & 4 deletions test_main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@

# Test data constants
TEST_BOOKS = [
{"title": "Carrie", "author": "Stephen King"},
{"title": "Ready Player One", "author": "Ernest Cline"},
{"title": "Carrie", "author": "Stephen King", "publisher": "Viking Press"},
{"title": "Ready Player One", "author": "Ernest Cline", "publisher": "Crown Publishing Group"},
]

class TestMainApp:
Expand Down Expand Up @@ -57,7 +57,7 @@ def test_update_book(self, test_db):

def test_delete_book(self, test_db):
"""Test deleting a book"""
book = create_book(test_db, BookIn(title="To Delete", author="Author"))
book = create_book(test_db, BookIn(title="To Delete", author="Author", publisher="Test Publisher"))
deleted_book = delete_book(test_db, book.id)

assert deleted_book is not None
Expand All @@ -67,5 +67,5 @@ def test_delete_book(self, test_db):
def test_nonexistent_operations(self, test_db):
"""Test operations on nonexistent books"""
assert get_book(test_db, 999999) is None
assert update_book(test_db, 999999, BookIn(title="Test", author="Test")) is None
assert update_book(test_db, 999999, BookIn(title="Test", author="Test", publisher="Test Publisher")) is None
assert delete_book(test_db, 999999) is None