One Shot Timers#513
Open
JonathanKChang wants to merge 3 commits into
Open
Conversation
Add switch setting for one-shot timer deletion in timer settings schema and the corresponding ClockTimer.shouldDeleteAfterDismiss getter that reads the setting value.
Display a delete outline icon next to timer cards that have Delete After Finishing enabled, giving users visual feedback that the timer will be automatically removed after completion.
When a one-shot timer (Delete After Finishing enabled) is dismissed, immediately remove it from persistent storage and notify the UI isolate so the active list updates.
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a “Delete After Finishing” option for timers that removes one‑shot timers from storage automatically when they are dismissed. Addresses #433
Changes
timer.shouldDeleteAfterFinishingis true:updatePort(updateTimersmessage) to refresh the timer list.timerDeleteAfterFinishingSettingstring toapp_en.arb.SwitchSettingnamed “Delete After Finishing” (defaultfalse) intimerSettingsSchema.shouldDeleteAfterFinishinggetter that reads the new setting.Notes
"updateTimers"message; existing UI code already handles generic timer‑list refreshes.