Disable notifications on disconnect + race condition fix#227
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR improves BLE disconnect behavior by explicitly disabling characteristic notifications before disconnecting, and hardens several OnCharacteristicChanged handlers against null characteristic references (avoiding a common disconnect/notification race).
Changes:
- Add
BeforeDisconnectAsyncoverrides to disable BLE notifications prior to disconnect for multiple device types. - Update
OnCharacteristicChangedguards to handle cases where the notify characteristic reference is null (disconnect race / early callback).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
BrickController2/BrickController2/DeviceManagement/Wedo2Device.cs |
Disable sensor notification before disconnect. |
BrickController2/BrickController2/DeviceManagement/PfxBrickDevice.cs |
Fix disconnect/notification race guard + disable notification before disconnect. |
BrickController2/BrickController2/DeviceManagement/CircuitCubeDevice.cs |
Fix disconnect/notification race guard + disable notification before disconnect. |
BrickController2/BrickController2/DeviceManagement/BuWizz3Device.cs |
Fix disconnect/notification race guard + disable notification before disconnect. |
BrickController2/BrickController2/DeviceManagement/BuWizz2Device.cs |
Fix disconnect/notification race guard + disable notification before disconnect. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
vicocz
changed the title
vicocz
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.