add generic component to useGeometries#674
Open
gmulz wants to merge 2 commits into
Open
Conversation
🦋 Changeset detectedLatest commit: 8e23a68 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
DTCurrie
reviewed
May 12, 2026
| const cameras = useResourceNames(partID, 'camera') | ||
| const grippers = useResourceNames(partID, 'gripper') | ||
| const gantries = useResourceNames(partID, 'gantry') | ||
| const generics = useResourceNames(partID, 'generic') |
Member
There was a problem hiding this comment.
Any issues with this and generic services?
Member
Author
There was a problem hiding this comment.
fixed, but is this a shortcoming of the svelte sdk that i can't filter by anything other than subtype?
DTCurrie
requested changes
May 12, 2026
Member
DTCurrie
left a comment
DTCurrie
left a comment
There was a problem hiding this comment.
don't forget to add a changeset
micheal-parks
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
merged a change to rdk that adds GetGeometries to generic components (seems like a bug that it was not implemented) and now closing the loop so the 3d scene tab can visualize generic components with geometries. should let us do very simple things like make obstacles out of meshes that aren't implemented as "grippers" for no reason
tested this locally and it does work with the rdk changes (i forgot to take a screenshot before shutting everything off but trust me it works)
rdk pr: viamrobotics/rdk#5999