-
Notifications
You must be signed in to change notification settings - Fork 1
Fix/permissions too large in jwt #499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
8ac9d13
fix: badly compress jwt
Paulijuz c618210
chore: add proper title to website
Paulijuz dd70c97
docs: add explanatory comment for why we log invalid JWT sessions as …
Paulijuz 16d325f
chore: sanctus -> sct. to fit better
Paulijuz e719144
fix: copilot comments
Paulijuz 257b34b
style: login in button widths
Paulijuz 9d9181b
chore: add title template
Paulijuz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,71 @@ | ||
| import { deflate, inflate } from 'zlib' | ||
| import { promisify } from 'util' | ||
| import type { JWT } from 'next-auth/jwt' | ||
|
|
||
| // THIS WACKY COMPRESSING AND DECOMPRESSING STUFF IS TEMPORARY | ||
| // TO REDUCE JWT SIZE UNTIL WE HAVE EITHER: | ||
| // 1) MORE REASONABLE PERMISSIONS ENCODING | ||
| // 2) SWITCHED TO DATABASE SESSIONS | ||
| // 3) FIX THE JWT TYPE TO SUPPORT COMPRESSION PROPERLY | ||
|
|
||
| const deflateAsync = promisify(deflate) | ||
| const inflateAsync = promisify(inflate) | ||
|
|
||
| // eslint-disable-next-line | ||
| async function compressField(data: any): Promise<any> { | ||
| try { | ||
| const buffer = await deflateAsync(JSON.stringify(data)) | ||
| return buffer.toString('base64') | ||
| } catch (error) { | ||
| console.error('Failed to compress JWT field: ', error) | ||
|
|
||
| return null | ||
| } | ||
| } | ||
|
|
||
| // eslint-disable-next-line | ||
| async function decompressField(data: any): Promise<any> { | ||
| try { | ||
| const buffer = Buffer.from(data, 'base64') | ||
| const inflated = await inflateAsync(buffer) | ||
| return JSON.parse(inflated.toString()) | ||
| } catch (error) { | ||
| console.error('Failed to decompress JWT field: ', error) | ||
|
|
||
| return null | ||
| } | ||
| } | ||
|
|
||
| const fieldsToCompress: (keyof JWT)[] = ['permissions', 'memberships', 'user'] | ||
|
|
||
| export async function compressJwt(token: JWT | undefined): Promise<JWT | undefined> { | ||
| if (!token) return token | ||
|
|
||
| const compressedJwt = { ...token } | ||
|
|
||
| for (const field of fieldsToCompress) { | ||
| if (field in compressedJwt) { | ||
| compressedJwt[field] = await compressField(compressedJwt[field]) | ||
| } | ||
| } | ||
|
|
||
| return compressedJwt | ||
| } | ||
|
|
||
| export async function decompressJwt(token: JWT): Promise<JWT | null> { | ||
| const decompressedJwt = { ...token } | ||
|
|
||
| for (const field of fieldsToCompress) { | ||
| if (field in decompressedJwt) { | ||
| const decompressedField = await decompressField(decompressedJwt[field]) | ||
|
|
||
| if (decompressedField === null) { | ||
| return null | ||
| } | ||
|
|
||
| decompressedJwt[field] = decompressedField | ||
| } | ||
| } | ||
|
|
||
| return decompressedJwt | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.