fix: prevent crash on unmounted context after opening markdown link#21
fix: prevent crash on unmounted context after opening markdown link#21
Conversation
Added `if (!context.mounted) return;` checks after `await launchUrl(...)` in `_openMarkdownLink` within `chat_message_text_part.dart`. This prevents potential runtime crashes and resolves `use_build_context_synchronously` warnings when attempting to show snackbar feedback if the widget has been unmounted. Co-authored-by: insign <1113045+insign@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
1 participant
Fixes potential
StateErrorcrashes anduse_build_context_synchronouslyanalyzer warnings by verifyingcontext.mountedafter asynchronous operations. This ensures that snackbar feedback is only displayed if the widget remains in the tree after thelaunchUrlcall completes.if (!context.mounted) return;check before_showLinkOpenFeedbackon link open failure.if (!context.mounted) return;check before_showLinkOpenFeedbackin the error catch block.PR created automatically by Jules for task 322666166495636790 started by @insign