New progress bar for unknown amount of iterations in advance#26
Open
farchy wants to merge 6 commits intoverigak:masterfrom
Open
New progress bar for unknown amount of iterations in advance#26farchy wants to merge 6 commits intoverigak:masterfrom
farchy wants to merge 6 commits intoverigak:masterfrom
Conversation
Fixed tests to reflect
Added tests for the AdaptiveBar Fixed README.rst
Owner
|
Hi, this is very interesting, but the implementation can be simplified a lot. You can implement an class AdaptiveBar(AdaptiveMixin, IncrementalBar): passThat way you can make any of the existing bars become adaptive. |
Author
|
ACK, will change the implementation... |
Owner
|
Let's keep working on this one for now and see if we can squash the commits in the end. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a new progress bar for infinite (unknown
max) iterations.Added a test for it in
test_progress.py