-
Notifications
You must be signed in to change notification settings - Fork 148
[cli] Print notice on CLI startup when detecting an outdated version #701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
VaguelySerious
wants to merge
5
commits into
main
Choose a base branch
from
peter/cli-check-for-updates-manual
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+277
−4
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
d2e0aba
[cli] Print notice on CLI startup when detecting an outdated version
VaguelySerious ef9ffe6
Fixes
VaguelySerious f431229
Up cache
VaguelySerious 6b4d21a
Make three days
VaguelySerious d2b7e22
Add comment for clarification
VaguelySerious File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@workflow/cli": patch | ||
| --- | ||
|
|
||
| Display a notice when using an outdated version of the workflow package |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,233 @@ | ||
| import { mkdir, readFile, writeFile } from 'node:fs/promises'; | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. is there an npm package we can use to already do this update check? I think a lot of projects do this (including vercel/vercel) so we don't have to reinvent the wheel on this I think? |
||
| import { dirname } from 'node:path'; | ||
| import { logger } from './config/log.js'; | ||
|
|
||
| // Constants | ||
| const PACKAGE_NAME = '@workflow/cli'; | ||
| const NPM_REGISTRY = 'https://registry.npmjs.org'; | ||
| const CACHE_DURATION_MS = 3 * 24 * 60 * 60 * 1000; // 3 days | ||
| const REQUEST_TIMEOUT_MS = 5000; | ||
|
|
||
| interface VersionCheckResult { | ||
| currentVersion: string; | ||
| latestVersion?: string; | ||
| needsUpdate: boolean; | ||
| } | ||
|
|
||
| interface CachedVersionData { | ||
| currentVersion: string; | ||
| latestVersion: string; | ||
| timestamp: number; | ||
| } | ||
|
|
||
| /** | ||
| * Compare two semver versions including pre-release tags | ||
| * Returns true if version a is greater than version b | ||
| */ | ||
| function compareVersions(a: string, b: string): boolean { | ||
| const parseVersion = (v: string) => { | ||
| const [base, prerelease] = v.split('-'); | ||
| const parts = base.split('.').map(Number); | ||
| return { parts, prerelease }; | ||
| }; | ||
|
|
||
| const versionA = parseVersion(a); | ||
| const versionB = parseVersion(b); | ||
|
|
||
| // Compare major, minor, patch | ||
| for (let i = 0; i < 3; i++) { | ||
| if (versionA.parts[i] > versionB.parts[i]) return true; | ||
| if (versionA.parts[i] < versionB.parts[i]) return false; | ||
| } | ||
|
|
||
| // If versions are equal up to patch level, check prerelease | ||
| // No prerelease is considered greater than prerelease | ||
| if (!versionA.prerelease && versionB.prerelease) return true; | ||
| if (versionA.prerelease && !versionB.prerelease) return false; | ||
|
|
||
| // Both have prereleases or both don't - they're equal | ||
| if (versionA.prerelease && versionB.prerelease) { | ||
| return versionA.prerelease > versionB.prerelease; | ||
| } | ||
|
|
||
| return false; | ||
| } | ||
|
|
||
| /** | ||
| * Fetch the latest version from npm registry | ||
| */ | ||
| async function fetchLatestVersion( | ||
| currentVersion: string | ||
| ): Promise<string | null> { | ||
| try { | ||
| const controller = new AbortController(); | ||
| const timeoutId = setTimeout(() => controller.abort(), REQUEST_TIMEOUT_MS); | ||
|
|
||
| const url = `${NPM_REGISTRY}/${PACKAGE_NAME}`; | ||
| logger.debug(`Checking for updates at ${url}`); | ||
|
|
||
| const response = await fetch(url, { | ||
| headers: { | ||
| Accept: 'application/json', | ||
| }, | ||
| signal: controller.signal, | ||
| }); | ||
|
|
||
| clearTimeout(timeoutId); | ||
|
|
||
| if (!response.ok) { | ||
| logger.debug( | ||
| `Failed to fetch package info: ${response.status} ${response.statusText}` | ||
| ); | ||
| return null; | ||
| } | ||
|
|
||
| const data = (await response.json()) as { | ||
| 'dist-tags': { [tag: string]: string }; | ||
| }; | ||
|
|
||
| // Always use 'latest' tag - even beta versions are published as latest | ||
| const latestVersion = data['dist-tags']['latest']; | ||
| if (!latestVersion) { | ||
| logger.debug('No latest version found in registry'); | ||
| return null; | ||
| } | ||
|
|
||
| logger.debug(`Current: ${currentVersion}, Latest: ${latestVersion}`); | ||
| return latestVersion; | ||
| } catch (error) { | ||
| if (error instanceof Error && error.name === 'AbortError') { | ||
| logger.debug('Version check timed out after 5 seconds'); | ||
| } else { | ||
| logger.debug(`Error fetching version: ${error}`); | ||
| } | ||
| return null; | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * Check if there's a new version available | ||
| * Returns the current and latest version if an update is available | ||
| */ | ||
| export async function checkForUpdate( | ||
| currentVersion: string | ||
| ): Promise<VersionCheckResult> { | ||
| const latestVersion = await fetchLatestVersion(currentVersion); | ||
|
|
||
| if (!latestVersion) { | ||
| return { | ||
| currentVersion, | ||
| needsUpdate: false, | ||
| }; | ||
| } | ||
|
|
||
| const needsUpdate = compareVersions(latestVersion, currentVersion); | ||
|
|
||
| return { | ||
| currentVersion, | ||
| latestVersion, | ||
| needsUpdate, | ||
| }; | ||
| } | ||
|
|
||
| /** | ||
| * Read cached version data from file | ||
| */ | ||
| async function readCache(cacheFile: string): Promise<CachedVersionData | null> { | ||
| try { | ||
| const content = await readFile(cacheFile, 'utf-8'); | ||
| const data = JSON.parse(content) as CachedVersionData; | ||
| return data; | ||
| } catch { | ||
| return null; | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * Write version data to cache file | ||
| */ | ||
| async function writeCache( | ||
| cacheFile: string, | ||
| data: CachedVersionData | ||
| ): Promise<void> { | ||
| try { | ||
| await mkdir(dirname(cacheFile), { recursive: true }); | ||
| await writeFile(cacheFile, JSON.stringify(data, null, 2)); | ||
| } catch (error) { | ||
| logger.debug(`Failed to write version cache: ${error}`); | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * Check if cache is still valid | ||
| */ | ||
| async function isCacheValid( | ||
| cacheFile: string, | ||
| currentVersion: string | ||
| ): Promise<boolean> { | ||
| try { | ||
| const cached = await readCache(cacheFile); | ||
| if (!cached) return false; | ||
|
|
||
| // Cache is invalid if version changed | ||
| if (cached.currentVersion !== currentVersion) { | ||
| logger.debug('Version changed, cache invalidated'); | ||
| return false; | ||
| } | ||
|
|
||
| // Check if cache is still fresh | ||
| const now = Date.now(); | ||
| const age = now - cached.timestamp; | ||
| const isValid = age < CACHE_DURATION_MS; | ||
|
|
||
| if (!isValid) { | ||
| logger.debug( | ||
| `Cache expired (age: ${Math.floor(age / 1000 / 60)} minutes)` | ||
| ); | ||
| } | ||
|
|
||
| return isValid; | ||
| } catch { | ||
| return false; | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * Check for updates with filesystem caching | ||
| * Cache is valid for 1 day unless the local version changes | ||
| */ | ||
| export async function checkForUpdateCached( | ||
| currentVersion: string, | ||
| cacheFile: string | ||
| ): Promise<VersionCheckResult> { | ||
| // Check if cache is valid | ||
| if (await isCacheValid(cacheFile, currentVersion)) { | ||
| logger.debug('Using cached version check result'); | ||
| const cached = await readCache(cacheFile); | ||
| if (cached) { | ||
| return { | ||
| currentVersion: cached.currentVersion, | ||
| latestVersion: cached.latestVersion, | ||
| needsUpdate: compareVersions( | ||
| cached.latestVersion, | ||
| cached.currentVersion | ||
| ), | ||
| }; | ||
| } | ||
| } | ||
|
|
||
| // Perform fresh check | ||
| logger.debug('Performing fresh version check'); | ||
| const result = await checkForUpdate(currentVersion); | ||
|
|
||
| // Cache the result if we got a latest version | ||
| if (result.latestVersion) { | ||
| await writeCache(cacheFile, { | ||
| currentVersion: result.currentVersion, | ||
| latestVersion: result.latestVersion, | ||
| timestamp: Date.now(), | ||
| }); | ||
| } | ||
|
|
||
| return result; | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no
bun? 😢bun>yarn:)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also if you install
@latestI think it will use@latestin the user's package.json - so I'd actually recommendpnpm i workflow@${updateCheck.latestVersion}I thinkThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we also include a link to the changelog on github?