fix(streamdown): improve mermaid diagram sizing and responsiveness#471
Open
ayhansipahi wants to merge 1 commit intovercel:mainfrom
Open
fix(streamdown): improve mermaid diagram sizing and responsiveness#471ayhansipahi wants to merge 1 commit intovercel:mainfrom
ayhansipahi wants to merge 1 commit intovercel:mainfrom
Conversation
Constrain SVG diagrams to container width with max-w-full and h-auto, increase minimum container height, and align items to start in non-fullscreen mode.
Contributor
|
@ayhansipahi is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Mermaid SVG diagrams could overflow their container, especially on smaller viewports. This PR constrains diagrams to their container width and improves layout consistency.
Type of Change
Related Issues
Changes Made
max-w-full,h-auto, andw-fullCSS classesmin-w-0to chart container for proper flexbox shrinkingmin-h-28tomin-h-48for better initial layoutitems-startinstead of no alignmentTesting
Test Coverage
Added 2 new tests:
should apply responsive sizing classes to chart container— verifiesw-full,min-w-0,items-startin normal modeshould apply fullscreen alignment to chart container— verifiesitems-center,size-fullin fullscreen modeAll 17 mermaid component tests pass.
Checklist
pnpm changeset)Changeset