Make whether a param has a default be a separate field from quals#118
Open
msullivan wants to merge 2 commits into
Open
Make whether a param has a default be a separate field from quals#118msullivan wants to merge 2 commits into
msullivan wants to merge 2 commits into
Conversation
Drop "default" from ParamQuals and add a fourth generic D = Never to Param. The presence of a default is now expressed by D being a real type (e.g. the parameter's type) instead of by a string in the qual set, which makes the default's type available to type-level operators via the new GetDefault[T: Param] alias.
For simple default types (None, int, str, bytes, bool, enum), store D = Literal[value] instead of D = ann_type, allowing real values to be extracted when converting back to inspect.Signature.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also allow it to carry the literal for it, for simple types.
This is extracted from #83, to separate it from the enum stuff.
Two mypy tests xfailed.