Avoid Set in missing slots RSC payload#94216
Open
hukuda222 wants to merge 3 commits into
Open
Conversation
39618b2 to
f62a09a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Avoid sending the dev-only
missingSlotsvalue as aSetin the initial RSC payload. The payload now carries missing slots as a string array only when there are actually missing slots, and the client reconstructs theSetbefore providingMissingSlotContext.Why?
In development, pages without missing parallel route slots can still include an empty
SetatinitialRSCPayload.m, which triggers this warning:This warning points users at application Server/Client Component props even though the
Setcomes from Next.js internals.How?
missingSlotsasstring[] | undefinedinInitialRSCPayload.mwhen the set is empty.Set<string>on the client only when missing slots are present.Fixes #73323
Testing
pnpm installpnpm build-allpnpm --filter=next typespnpm exec prettier --check packages/next/src/client/app-index.tsx packages/next/src/server/app-render/app-render.tsx packages/next/src/shared/lib/app-router-types.ts test/e2e/app-dir/rsc-basic/rsc-basic.test.tspnpm lint-eslint packages/next/src/client/app-index.tsx packages/next/src/server/app-render/app-render.tsx packages/next/src/shared/lib/app-router-types.ts test/e2e/app-dir/rsc-basic/rsc-basic.test.tspnpm test-dev-turbo test/e2e/app-dir/rsc-basic/rsc-basic.test.ts