Open
Conversation
Contributor
|
@madhusudhand is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
2197898 to
119dc8c
Compare
119dc8c to
a742844
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a Supaship adapter for the Flags SDK via a new
@flags-sdk/supashippackage, along with tests and documentation.It also adds Supaship to the providers catalog in the docs so users can discover and use it as a flag provider.
Motivation
The Flags SDK is designed to support multiple providers through a consistent adapter interface. This PR extends that ecosystem by enabling Supaship as a compatible provider.
This allows teams using Supaship to adopt the Flags SDK without changing their flag evaluation patterns.
Changes
New adapter package:
@flags-sdk/supashippackage.jsontsconfig.jsontsup.config.jsvitest.config.tsCHANGELOG.mdpackages/adapter-supaship/src/index.ts:createSupashipAdapter(...)factorysupashipAdapterfeature().decide(...)flow that:defaultValueonnull/undefinedpackages/adapter-supaship/src/index.test.tsfor:undefinedandnulldefaultValueexistsDocumentation updates
apps/docs/content/docs/providers/supaship.mdxfeature()usage exampleapps/docs/content/docs/providers/meta.jsonapps/docs/components/custom/logos/supaship.tsxapps/docs/components/custom/provider-list.tsxDependency/lockfile updates
@supashiphq/javascript-sdk@1.0.0to package graph for the new adapter package.Test plan
pnpm --filter @flags-sdk/supaship testpnpm --filter @flags-sdk/supaship type-checkpnpm --filter @flags-sdk/supaship buildpnpm --filter docs devand verify Supaship appears in provider list and docs page renders/examples are correct