Skip to content

[code quality] avoid shadowing "flag" function name #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dferber90 merged 1 commit into from
Dec 5, 2025
Merged

[code quality] avoid shadowing "flag" function name #228

dferber90 merged 1 commit into from
Dec 5, 2025

Conversation

@dferber90
Copy link
Collaborator

@dferber90 dferber90 commented Dec 5, 2025

We were essentially using the below, which shadows the flag name making the code harder to read

function flag() {
  const flag = () => {}
  return flag
}

This PR cleans it up so we have

function flag() {
  const api = () => {}
  return api
}

@dferber90 dferber90 requested a review from a team December 5, 2025 08:08
@vercel
Copy link
Contributor

vercel bot commented Dec 5, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
shirt-shop Ready Ready Preview Dec 5, 2025 8:08am

@dferber90 dferber90 merged commit 1147254 into main Dec 5, 2025
13 checks passed
@dferber90 dferber90 deleted the rename-flag-internally branch December 5, 2025 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vincent-derks vincent-derks vincent-derks approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dferber90 @vincent-derks