fix: Fail scan when --matchers contains unknown slugs#35
Open
divyamagrawal06 wants to merge 1 commit into
Open
fix: Fail scan when --matchers contains unknown slugs#35divyamagrawal06 wants to merge 1 commit into
divyamagrawal06 wants to merge 1 commit into
Conversation
|
@divyamagrawal06 is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
Please re-push with signed commits |
Fail scan when --matchers includes unknown slugs. Fix README grammar (deepsec is an...). Signed-off-by: Divyam Agrawal <ludicrouslytrue@gmail.com>
divyamagrawal06
force-pushed
the
fix/strict-unknwon-matching
branch
from
7e50611 to
7dfe161
Compare
Author
Done, also made a small typo fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #34
What changed
Changed matcher slug lookup so
deepsec scan --matchersfails when any requested slug is unknown instead of silently dropping missing slugs. Added e2e coverage for a mixed valid/invalid matcher list.Why
When
deepsec scan --matchersincludes an unknown matcher slug, deepsec silently ignores the unknown slug and scans with only the known matchers. This makes an invalid scan request look successful.Verification
pnpm testpassespnpm lintpassespnpm knippassesUnknown matcher slug(s): does-not-existand exits 1Notes for reviewer
Before:
After:
Environment
deepsec version: 1.1.13
Node version (node --version): v24.14.0
OS: Linux (Ubuntu) through WSL (Win 11)