acp registry support#28
Open
andymac4182 wants to merge 4 commits into
Open
Conversation
|
@andymac4182 is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
a6a1395 to
67738fe
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Added an ACP-backed agent plugin for DeepSec
processandrevalidate, with support for ACP registry agents andexplicit custom ACP bridge commands.
Why
DeepSec should be able to run investigations and revalidation through any Agent Client Protocol-compatible server, not
just built-in Claude/Codex integrations. Requiring an explicit registry agent or command avoids hidden local defaults
and makes the selected ACP backend clear and reproducible.
Verification
pnpm testpassespnpm lintpassespnpm knippassesAdditional targeted checks:
pnpm exec vitest run --project processor packages/processor/src/__tests__/acp-agent.test.ts packages/processor/src/__tests__/registry.test.tspnpm exec vitest run --config packages/deepsec/vitest.config.ts --dir packages/deepsec src/__tests__/preflight.test.tspnpm --filter @deepsec/processor buildpnpm --filter deepsec buildpnpm exec biome check packages/processor/src/agents/acp-agent.ts packages/processor/src/__tests__/acp-agent.test.ts packages/deepsec/src/cli.ts packages/deepsec/src/commands/process.ts packages/deepsec/src/commands/revalidate.ts packages/deepsec/src/preflight.ts packages/deepsec/src/__tests__/preflight.test.ts docs/models.md docs/configuration.mdNote:
pnpm testrequires the bundled CLI artifact, so I ranpnpm bundlefirst.Notes for reviewer
ACP usage is explicit by design.
--agent acprequires either:or:
There is no default ACP agent and no local vendor-specific shortcut.
Registry support currently handles distribution.npx and distribution.uvx entries from:
Binary-only registry entries intentionally fail with an actionable error telling users to install the binary and pass
it through --acp-command.
Custom command examples:
pnpm deepsec process --project-id my-app --agent acp \ --acp-command 'my-acp serve --stdio'pnpm deepsec process --project-id my-app --agent acp \ --acp-command my-acp \ --acp-args '["serve","--stdio"]'Credential preflight is skipped for ACP agents because auth belongs to the selected ACP bridge/server rather than
DeepSec’s Claude/OpenAI environment checks.