Fix temporal example by making client init lazy?#151
Draft
msullivan wants to merge 1 commit into
Draft
Conversation
The temporal example got broken by `get_model` eagerly creating a provider, which creates an httpx client. httpx imports anyio, which uses threading.local, which apparently isn't allowed in a temporal workflow. Here is a fix based on lazily creating the model, which seems like a sort of plausible thing to do? Thoughts?
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The temporal example got broken by
get_modeleagerly creating aprovider, which creates an httpx client. httpx imports anyio, which
uses threading.local, which apparently isn't allowed in a temporal
workflow.
Here is a fix based on lazily creating the model, which seems like a
sort of plausible thing to do?
Thoughts?