Remove protocol= argument from stream() and generate()#141
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
anbuzin
approved these changes
May 19, 2026
Collaborator
anbuzin
left a comment
anbuzin
left a comment
There was a problem hiding this comment.
Wouldn't be an Elvis-pilled framework without a single .with_foo method
The `protocol=` argument was added as part of #101. The concrete protocol is really a provider property or a model/provider pair property and would be best to be kept on `Model` instances exclusively. To override the protocol using a pre-defined model instance, use the new `with_protocol` modifier returning a copy.
elprans
force-pushed
the
elprans/remove-protocol-param
branch
from
132184b to
5e9eba0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
protocol=argument was added as part of #101. The concreteprotocol is really a provider property or a model/provider pair property
and would be best to be kept on
Modelinstances exclusively. Tooverride the protocol using a pre-defined model instance, use the new
with_protocolmodifier returning a copy.