This repository was archived by the owner on Mar 9, 2022. It is now read-only.
improve test to use unittest framework to make it easy to run #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerrydboonstra
commented
Jan 5, 2022
jerrydboonstra
commented
- lets use our logging framework in our tests instead of printing to console
- do not redirect logging to a file, its better at stderr when in a test case, and we can see which threads log what
- exit our ws instances after use in tests, else they interact with the tests
… redirect logging to a file, its better at stderr when in a test case; lets use our logging framework in our tests instead of printing to console; exit our ws instances after use else they interact; drop return values which are None anyway
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.