Skip to content

Made the value of reason in authenticateWithBiometrics injectable #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ziogaschr merged 1 commit into from
Jun 12, 2016
Merged

Made the value of reason in authenticateWithBiometrics injectable #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion PasscodeLock/PasscodeLock/PasscodeLock.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,12 @@ public class PasscodeLock: PasscodeLockType {
guard isTouchIDAllowed else { return }

let context = LAContext()
let reason = localizedStringFor("PasscodeLockTouchIDReason", comment: "TouchID authentication reason")
let reason: String
if let configReason = configuration.touchIdReason {
reason = configReason
} else {
reason = localizedStringFor("PasscodeLockTouchIDReason", comment: "TouchID authentication reason")
}

context.localizedFallbackTitle = localizedStringFor("PasscodeLockTouchIDButton", comment: "TouchID authentication fallback button")

Expand Down
1 change: 1 addition & 0 deletions PasscodeLock/Protocols/PasscodeLockConfigurationType.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,6 @@ public protocol PasscodeLockConfigurationType {
var passcodeLength: Int {get}
var isTouchIDAllowed: Bool {get set}
var shouldRequestTouchIDImmediately: Bool {get}
var touchIdReason: String? {get set}
var maximumInccorectPasscodeAttempts: Int {get}
}
1 change: 1 addition & 0 deletions PasscodeLockTests/Fakes/FakePasscodeLockConfiguration.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ class FakePasscodeLockConfiguration: PasscodeLockConfigurationType {
var isTouchIDAllowed = false
let maximumInccorectPasscodeAttempts = 3
let shouldRequestTouchIDImmediately = false
var touchIdReason: String? = nil

init(repository: PasscodeRepositoryType) {

Expand Down