Raise errors on all unsuccessful HTTP response codes #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently not all unsuccessful HTTP response codes are treated as unsuccessful response.
That leads to an error on parsing response body later in the flow.
Solution
Vend::PaymentRequiredon HTTP code 402 -- that's observable behaviour of Vend API;Vend::HttpErroron all HTTP codes (including 0) other than 200..299.