Control Plane Timeline: Switch to descending date and fallback to mentioned_at for non events #56
+22
−14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #55
Introduce effective_date
Instead of using just occurred_start for display/ordering I've introduced an effective_date property to object in the withDates array: This will be occurred_start if present but otherwise will fallback to mentioned_at (or null if not set).
Sort order
It now sorts by effective_date in descending order, which seems to be consistent with the query on the api:
hindsight/hindsight-api/hindsight_api/engine/memory_engine.py
Lines 2082 to 2091 in 6d820ef
Testing
I've tested this manually with a memory bank of mine, verifying that opinions which previously were hidden now show and are ordered correctly.