Sourcefile open from testing pane #317
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #317 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 9 9
Lines 1658 1658
Branches 194 194
=========================================
Hits 1658 1658
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
| envData = await getDataForEnvironment(enviroPath); | ||
| } | ||
|
|
||
| if (envData && envData.unitData) { |
There was a problem hiding this comment.
Could you try reducing the nesting here a bit? For example by returning on opposite conditions etc. It's still understandable what's going on, so this is not so critical
| throw new Error(`Unit ${unitName} not found in Testing pane`); | ||
| } | ||
|
|
||
| // Open the source file through the context menu |
There was a problem hiding this comment.
I think it's fine that it's tested like this for now, cause there are multiple instances of stuff being tested like this. But there could be a refactor that'd make it clearer which test is verifying which feature/user flow - a separate one that would address all such instances. Here it'd be clear from the screenshot of the test failure which flow actually failed, so it's fine for now
Adds the Feature to open up a Source File from the Testing pane by either clicking on the unit or clikcing on a function within the units that also opens up the source file and focuses on where the function starts