fix(ci): include lib/ workspace crates in coverage reports#25402
Open
thomasqueirozb wants to merge 2 commits intomasterfrom
Open
fix(ci): include lib/ workspace crates in coverage reports#25402thomasqueirozb wants to merge 2 commits intomasterfrom
thomasqueirozb wants to merge 2 commits intomasterfrom
Conversation
thomasqueirozb
added
the
no-changelog
This comment was marked as outdated.
This comment was marked as outdated.
thomasqueirozb
changed the title
thomasqueirozb
commented
May 8, 2026
Contributor
Author
thomasqueirozb
left a comment
thomasqueirozb
left a comment
There was a problem hiding this comment.
/ci-run-coverage
thomasqueirozb
changed the title
thomasqueirozb
commented
May 8, 2026
Contributor
Author
thomasqueirozb
left a comment
thomasqueirozb
left a comment
There was a problem hiding this comment.
/ci-run-coverage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cargo llvm-cov reportand the integration test coverage command were both missing--workspace, so coverage data forlib/workspace crates was collected but then filtered out at report time — only the rootvectorpackage (src/) appeared in the output.Vector configuration
NA
How did you test this PR?
/ci-run-coverageCI run: https://github.com/vectordotdev/vector/actions/runs/25584248327?pr=25402
Change Type
Is this a breaking change?
Does this PR include user facing changes?
no-changeloglabel to this PR.References