chore(external docs): Clarify acknowledgement guarantees with disk buffers#25388
Open
chore(external docs): Clarify acknowledgement guarantees with disk buffers#25388
Conversation
c076b98 to
deffe50
Compare
thomasqueirozb
approved these changes
May 7, 2026
OliviaShoup
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This updates the guarantees docs to avoid overstating disk buffers as a standalone delivery guarantee.
The FAQ now points users toward components that support end-to-end acknowledgements, and says disk buffers improve durability for events written to them without guaranteeing end-to-end delivery on their own.
Why
The previous wording said events would not be lost once inside Vector if on-disk buffers were configured. That was too broad and did not reflect the role of end-to-end acknowledgements.