fix(sources): exclude journald source from musl/Alpine builds #24528
+25
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
domain: external docs
thomasqueirozb
added
the
no-changelog
Contributor
Author
|
This PR will stay drafted for now - deleting the source from compilation might not be the right path forward because it can then start failing valid configs if an alpine vector image is used to run unit-test or validate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Excludes the
journaldsource from Alpine/musl-based Vector builds since Alpine Linux uses OpenRC instead of systemd. Neither the journald daemon nor thejournalctlbinary are available on Alpine, making the source non-functional.Vector configuration
NA
How did you test this PR?
Verified the Cargo.toml changes properly exclude journald from musl targets while keeping it available for glibc-based builds.
Change Type
Is this a breaking change?
Does this PR include user facing changes?
no-changeloglabel to this PR.References