Skip to content

Conversation

@gwenaskell
Copy link
Contributor

@gwenaskell gwenaskell commented Jan 14, 2026

Summary

The error type returned from the enrichment::Table trait methods results is a plain string which does not help to check if the lookup error is either caused by an invalid input, a row not found or multiple rows found. This PR wraps it in an enum which makes this explicit.

How did you test this PR?

unit tests

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the no-changelog label to this PR.

References

  • Closes: #OPA-4299
  • Related: #OPA-4226

Notes

  • Please read our Vector contributor resources.
  • Do not hesitate to use @vectordotdev/vector to reach out to us regarding this PR.
  • Some CI checks run only after we manually approve them.
    • We recommend adding a pre-push hook, please see this template.
    • Alternatively, we recommend running the following locally before pushing to the remote branch:
      • make fmt
      • make check-clippy (if there are failures it's possible some of them can be fixed with make clippy-fix)
      • make test
  • After a review is requested, please avoid force pushes to help us review incrementally.
    • Feel free to push as many commits as you want. They will be squashed into one before merging.
    • For example, you can run git merge origin master and git push.
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run make build-licenses to regenerate the license inventory and commit the changes (if any). More details here.

@gwenaskell gwenaskell changed the title wrap enrichment errors in a custom type chore(enrichment): wrap enrichment errors in a custom type Jan 14, 2026
@gwenaskell gwenaskell changed the title chore(enrichment): wrap enrichment errors in a custom type chore(enrichment tables): wrap enrichment errors in a custom type Jan 14, 2026
@bruceg bruceg added type: tech debt A code change that does not add user value. domain: transforms Anything related to Vector's transform components domain: enriching Anything related to enriching Vector's events with context data domain: enrichment_tables Anything related to the Vector's enrichment tables no-changelog Changes in this PR do not need user-facing explanations in the release changelog labels Jan 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain: enriching Anything related to enriching Vector's events with context data domain: enrichment_tables Anything related to the Vector's enrichment tables domain: transforms Anything related to Vector's transform components no-changelog Changes in this PR do not need user-facing explanations in the release changelog type: tech debt A code change that does not add user value.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants