Conversation
…ove block size check so that it applies for all downloads
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a few CLI/converter robustness issues: it tightens converter class selection, makes verbose logging configurable via environment, and ensures the “avoid range requests” block-size behavior is applied consistently during downloads.
Changes:
- Restrict converter class discovery to classes defined in the target converter module (avoids picking imported subclasses).
- Add env-controlled verbose mode in
LoggerMixin. - Move
block_size=0injection intodownload_files()so it applies to all download paths, not justconvert().
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| vecorel_cli/converters.py | Narrows class selection to classes defined in the converter module. |
| vecorel_cli/conversion/base.py | Centralizes avoid_range_request/block_size behavior inside download_files(). |
| vecorel_cli/cli/logger.py | Enables verbose mode via environment variable. |
| CHANGELOG.md | Adds v0.2.14 release notes and updates compare links. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Load the correct class for converters, enable verbose mode via env, move block size check so that it applies for all downloads