Skip to content

fix: parse boolean and int attributes value#69

Open
amihalj wants to merge 1 commit intovb:masterfrom
amihalj:fix/parse-boolean-and-int-attributes
Open

fix: parse boolean and int attributes value#69
amihalj wants to merge 1 commit intovb:masterfrom
amihalj:fix/parse-boolean-and-int-attributes

Conversation

@amihalj
Copy link

@amihalj amihalj commented Sep 15, 2023

Considering example:

<div
  class="lazyframe"
  data-vendor=""
  data-title=""
  data-thumbnail=""
  data-src=""
  data-ratio="1:1"
  data-initinview="false"
  data-autoplay="false"
></div>

Even-though data-autoplay="false" autoplay will be considered as true due to string value. This results in all attributes being evaluated as strings.

explicitly examing ['autoplay','initinview'] as boolean and ['debounce'] as integer will values passed as attributes correspond to preferred types

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant