fix(isMobilePhone): fix mk-MK regex to correctly validate Macedonian mobile numbers#2687
Open
abdulazizkhatamov wants to merge 1 commit intovalidatorjs:masterfrom
Open
Conversation
…mobile numbers
The previous regex used `7[0-9][2-9]\d{5}` which incorrectly restricted
the third digit to 2-9, causing valid mobile numbers like +38970123456
and 070123456 (070-079 range) to fail validation. Fixed to `7[0-9]\d{6}`
to allow all valid Macedonian mobile operator prefixes.
Fixes validatorjs#2497
abdulazizkhatamov
force-pushed
the
fix/mk-MK-mobile-phone
branch
from
29134a9 to
02c47ba
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2687 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 114 114
Lines 2595 2595
Branches 659 659
=========================================
Hits 2595 2595 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rubiin
approved these changes
Mar 15, 2026
There was a problem hiding this comment.
Pull request overview
Fixes Macedonian (mk-MK) mobile number validation in isMobilePhone by correcting an overly restrictive regex that rejected valid 070–079 operator prefixes.
Changes:
- Update
mk-MKregex to allow all07xmobile prefixes (e.g.,070,071, …,079). - Add test cases covering
+38970.../+38971.../+38975.../+38979...and national070.../071.../075...formats.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/lib/isMobilePhone.js |
Loosens the mk-MK mobile subpattern from 7[0-9][2-9]... to 7[0-9]... to accept 070–079. |
test/validators.test.js |
Adds regression tests ensuring valid Macedonian mobile numbers in the 070–079 range pass validation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2497
The previous regex used
7[0-9][2-9]\d{5}which incorrectly restrictedthe third digit to 2-9, causing all valid Macedonian mobile numbers in the
070-079 range (e.g. +38970123456, 070123456) to fail validation.
Fixed to
7[0-9]\d{6}to allow all valid mobile operator prefixes.Checklist