feat: add one-shot provisioning for keycloak-users ExternalSecret#14
Open
minmzzhang wants to merge 1 commit into
Open
feat: add one-shot provisioning for keycloak-users ExternalSecret#14minmzzhang wants to merge 1 commit into
minmzzhang wants to merge 1 commit into
Conversation
sabre1041
requested changes
May 21, 2026
When externalSecrets.oneShot is true, the keycloak-users ExternalSecret becomes an ArgoCD Sync hook with BeforeHookCreation and deletionPolicy: Retain. This allows a PostSync job in the rh-keycloak wrapper chart (layered-zero-trust) to delete the ExternalSecret with --cascade=orphan so the Secret survives initial provisioning, then clean up ephemeral Secrets labeled for deletion. Defaults to false (oneShot disabled) — keycloak-users is a regular ExternalSecret with no hook annotations. The Secret and ExternalSecret simply persist. The rh-keycloak wrapper chart in layered-zero-trust enables it via rhbk.externalSecrets.oneShot. Also fixes NATURAL_LANGUAGE linter errors: postgresql -> PostgreSQL in values.yaml comments and README.md.gotmpl. Bump chart version to 0.0.9. Signed-off-by: Min Zhang <minzhang@redhat.com>
minmzzhang
force-pushed
the
one-shot-keycloak-users
branch
from
3c201dd to
0f3c0a3
Compare
sabre1041
approved these changes
May 22, 2026
Contributor
sabre1041
left a comment
sabre1041
left a comment
There was a problem hiding this comment.
this implementation will retain the prior default configuration.
Additional work will be needed to attempt to handle the orphan/deletion use case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When externalSecrets.oneShot is true, the keycloak-users ExternalSecret becomes an ArgoCD Sync hook with BeforeHookCreation and deletionPolicy: Retain. This allows a PostSync job in the rh-keycloak wrapper chart (layered-zero-trust) to delete the ExternalSecret with --cascade=orphan so the Secret survives initial provisioning, then clean up ephemeral Secrets labeled for deletion.
Defaults to false (oneShot disabled) — keycloak-users is a regular ExternalSecret with no hook annotations. The Secret and ExternalSecret simply persist. The rh-keycloak wrapper chart in layered-zero-trust enables it via rhbk.externalSecrets.oneShot.
Bump chart version to 0.0.9.