Lookup infra objects for global params#485
Lookup infra objects for global params#485day0hero wants to merge 3 commits intovalidatedpatterns:mainfrom
Conversation
- infra.Status.ControlPlaneTopology is how we can programmatically determine the type of cluster we're on. - External=HyperShift - SingleReplica/HighlyAvailable-Traditional/Normal - infra.Status.APIServerURL is how we can programmatically determine the api address of the cluster. - In the past we have gotten away with this because we could use the clusterDomain but HyperShift uses the DNS name of the ELB it provisions for the hosted cluster. - In addition to these changes, added a sample pattern crd for testing the operator.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: day0hero The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
hack/operator-build-deploy.sh
Outdated
There was a problem hiding this comment.
Don't delete this one, we love it ;)
|
|
||
| output.Status.ClusterPlatform = string(clusterInfra.Spec.PlatformSpec.Type) | ||
| } | ||
|
|
There was a problem hiding this comment.
Just look up the two new fields here, add them to the status and then place them in the values parameters. I think there is no need to add all that code in other places
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
2 participants
infra.Status.ControlPlaneTopology is how we can programmatically
determine the type of cluster we're on.
External=HyperShift
SingleReplica/HighlyAvailable-Traditional/Normal
infra.Status.APIServerURL is how we can programmatically determine the
api address of the cluster.
In the past we have gotten away with this because we could use the
clusterDomain but HyperShift uses the DNS name of the ELB it
provisions for the hosted cluster.
In addition to these changes, added a sample pattern crd for testing
the operator.