fix: enabled query should not use refFn #84
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greptile Overview
Greptile Summary
Fixed a bug where the
enabledproperty was prematurely callingrefFn()to determine if a query should run. Theenabledproperty in React Query should be based on static values and not execute functions with potential side effects.documentSnapshotQueryOptions, changed fromenabled: refFn ? !!refFn() : !!reftoenabled: !!refschemaDocumentSnapshotQueryOptions, added explicitenabled: !!idcontrolThis aligns with the pattern used in
querySnapshotQueryOptions(line 67) which usesenabled: !!querywithout callingqueryFn(). The fix ensures lazy evaluation ofrefFnonly when the query actually executes.Confidence Score: 5/5
refFn()was being called prematurely in theenabledproperty. The fix aligns with established patterns in the codebase (querySnapshotQueryOptionsuses the same approach) and existing tests validate the behavior. No breaking changes or side effects expected.Important Files Changed
File Analysis
enabledlogic to avoid callingrefFn()prematurely - now only checks!!refenabled: !!idto control query execution based on ID presence