feat: simplify staleTime for queryOptions #77
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greptile Overview
Greptile Summary
Refactored the
staleTimelogic inobservableQueryOptionsto directly check for active RxJS subscriptions instead of inferring state from query metadata. The new implementation checks if a subscription exists in thequeriesSubscriptionsMap usinghashKey(queryKey), which is more explicit and aligns better with the actual lifecycle of observable subscriptions.Key Changes:
state.dataUpdateCountandstate.statuschecks with directqueriesSubscriptions.has()lookupConfidence Score: 5/5
Important Files Changed
File Analysis
staleTimelogic to check active subscriptions directly instead of relying on query statestaleTimebehavior