Skip to content

Conversation

@Nr9
Copy link
Member

@Nr9 Nr9 commented Dec 3, 2025

Greptile Overview

Greptile Summary

Consolidated test mocking dependency management by hoisting vitest-mock-extended to the root workspace and removed spread operators from ESLint config arrays.

  • Moved vitest-mock-extended from individual packages to root package.json as a shared dev dependency
  • Added publicHoistPattern in pnpm-workspace.yaml to ensure vitest-mock-extended is available to all packages
  • Updated all ESLint configs to remove spread operators (configs now export single objects instead of arrays)
  • Added JSON linting support and .nx/ directory to global ignores
  • Removed empty .npmrc file
  • Minor dependency reordering in zustand-firestore/package.json

Confidence Score: 5/5

  • This PR is safe to merge with no issues found
  • All changes are configuration updates that improve dependency management and align with ESLint config updates from @valian/eslint-config. The dependency hoisting pattern follows pnpm best practices, and the ESLint config changes reflect an API update from the config package (configs now export single objects rather than arrays).
  • No files require special attention

Important Files Changed

File Analysis

Filename Score Overview
eslint.config.mjs 5/5 removed spread operators from config imports, added json linting, and excluded .nx/ from linting
package.json 5/5 added vitest-mock-extended as a root dev dependency for shared test mocking
packages/react-firestore/package.json 5/5 removed vitest-mock-extended dependency (now hoisted from root)
packages/react-kitchen-sink/package.json 5/5 removed vitest-mock-extended dependency (now hoisted from root)
packages/react-query-observable/package.json 5/5 removed vitest-mock-extended dependency (now hoisted from root)
packages/rxjs-firebase/package.json 5/5 removed vitest-mock-extended dependency (now hoisted from root)
packages/zustand-firestore/package.json 5/5 removed vitest-mock-extended dependency and reordered @testing-library/react to standard position
pnpm-workspace.yaml 5/5 added publicHoistPattern to hoist vitest-mock-extended to root for all packages

@Nr9 Nr9 requested a review from a team as a code owner December 3, 2025 17:53
@Nr9 Nr9 merged commit 0b0af78 into main Dec 3, 2025
5 checks passed
@Nr9 Nr9 deleted the project-config branch December 3, 2025 17:54
Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

14 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants