-
Notifications
You must be signed in to change notification settings - Fork 0
Support linux desktop tap events #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MartinMacek
wants to merge
2
commits into
main
Choose a base branch
from
feature/handle-linux-tap-events
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,134 @@ | ||
| import 'package:flutter/foundation.dart'; | ||
| import 'package:flutter/gestures.dart'; | ||
| import 'package:flutter/material.dart'; | ||
|
|
||
| /// A robust gesture detector that combines GestureDetector with fallback pointer handling | ||
| /// for better cross-platform compatibility, especially on Linux desktop touch screens. | ||
| class CustomGestureDetector extends StatefulWidget { | ||
| const CustomGestureDetector({ | ||
| super.key, | ||
| required this.child, | ||
| this.onTap, | ||
| this.onTapDown, | ||
| this.onTapUp, | ||
| this.onTapCancel, | ||
| this.onLongPress, | ||
| this.onLongPressStart, | ||
| this.onLongPressEnd, | ||
| this.behavior = HitTestBehavior.opaque, | ||
| this.excludeFromSemantics = false, | ||
| }); | ||
|
|
||
| final Widget child; | ||
| final VoidCallback? onTap; | ||
| final GestureTapDownCallback? onTapDown; | ||
| final GestureTapUpCallback? onTapUp; | ||
| final VoidCallback? onTapCancel; | ||
| final VoidCallback? onLongPress; | ||
| final GestureLongPressStartCallback? onLongPressStart; | ||
| final GestureLongPressEndCallback? onLongPressEnd; | ||
| final HitTestBehavior behavior; | ||
| final bool excludeFromSemantics; | ||
|
|
||
| @override | ||
| State<CustomGestureDetector> createState() => _CustomGestureDetectorState(); | ||
| } | ||
|
|
||
| class _CustomGestureDetectorState extends State<CustomGestureDetector> { | ||
| bool _isPressed = false; | ||
| int? _activePointerId; | ||
| bool _gestureHandled = false; | ||
|
|
||
| // Track if we're on a platform that might have touch issues | ||
| bool get _needsPointerFallback => | ||
| defaultTargetPlatform == TargetPlatform.linux; | ||
|
|
||
| void _handlePointerDown(PointerDownEvent event) { | ||
| if (_needsPointerFallback && _activePointerId == null) { | ||
| _activePointerId = event.pointer; | ||
| _isPressed = true; | ||
| _gestureHandled = false; | ||
| } | ||
| } | ||
|
|
||
| void _handlePointerUp(PointerUpEvent event) { | ||
| if (_needsPointerFallback && | ||
| _activePointerId == event.pointer && | ||
| _isPressed && | ||
| !_gestureHandled) { | ||
|
|
||
| _activePointerId = null; | ||
| _isPressed = false; | ||
|
|
||
| // Only trigger fallback if gesture detector didn't handle it | ||
| widget.onTapUp?.call(TapUpDetails( | ||
| kind: event.kind, | ||
| globalPosition: event.position, | ||
| localPosition: event.localPosition, | ||
| )); | ||
| widget.onTap?.call(); | ||
| } | ||
| } | ||
|
|
||
| void _handlePointerCancel(PointerCancelEvent event) { | ||
| if (_needsPointerFallback && | ||
| _activePointerId == event.pointer && | ||
| _isPressed && | ||
| !_gestureHandled) { | ||
|
|
||
| _activePointerId = null; | ||
| _isPressed = false; | ||
| widget.onTapCancel?.call(); | ||
| } | ||
| } | ||
|
|
||
| void _onGestureTapDown(TapDownDetails details) { | ||
| _gestureHandled = true; | ||
| widget.onTapDown?.call(details); | ||
| } | ||
|
|
||
| void _onGestureTapUp(TapUpDetails details) { | ||
| _gestureHandled = true; | ||
| _isPressed = false; | ||
| widget.onTapUp?.call(details); | ||
| } | ||
|
|
||
| void _onGestureTapCancel() { | ||
| _gestureHandled = true; | ||
| _isPressed = false; | ||
| widget.onTapCancel?.call(); | ||
| } | ||
|
|
||
| void _onGestureTap() { | ||
| _gestureHandled = true; | ||
| widget.onTap?.call(); | ||
| } | ||
|
|
||
| @override | ||
| Widget build(BuildContext context) { | ||
| Widget child = GestureDetector( | ||
| onTap: widget.onTap != null ? _onGestureTap : null, | ||
| onTapDown: widget.onTapDown != null ? _onGestureTapDown : null, | ||
| onTapUp: widget.onTapUp != null ? _onGestureTapUp : null, | ||
| onTapCancel: widget.onTapCancel != null ? _onGestureTapCancel : null, | ||
| onLongPress: widget.onLongPress, | ||
| onLongPressStart: widget.onLongPressStart, | ||
| onLongPressEnd: widget.onLongPressEnd, | ||
| behavior: widget.behavior, | ||
| excludeFromSemantics: widget.excludeFromSemantics, | ||
| child: widget.child, | ||
| ); | ||
|
|
||
| // Only add pointer fallback on platforms that need it | ||
| if (_needsPointerFallback) { | ||
| child = Listener( | ||
| onPointerDown: _handlePointerDown, | ||
| onPointerUp: _handlePointerUp, | ||
| onPointerCancel: _handlePointerCancel, | ||
| child: child, | ||
| ); | ||
| } | ||
|
|
||
| return child; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Consider making the platform check configurable rather than hardcoded. This would allow easier testing and future platform support without code changes. You could add a constructor parameter like
enablePointerFallbackwith a default value based on the platform check.