-
Notifications
You must be signed in to change notification settings - Fork 215
Fix broken charts styling examples, add Flow API example #4783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
AI Language Review
|
|
This PR is targeted at Vaadin 24. Does it apply to Vaadin 25 as well? |
Yes, it's equally applicable to V25. However, in the V25 docs, we need to mention that you need to enable shadow DOM style injection to use it. There is a note in the V25 Styling section about that: https://github.com/vaadin/docs/blob/main/articles/styling/index.adoc |
rolfsmeds
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More of a question than a request to change... otherwise looks good to me.
Would be great to port to V25 docs (where it also needs to be noted that component shadow DOM css styling needs to be enabled)
7c8ca0d to
0af4652
Compare
rolfsmeds
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, except for that period :)
Co-authored-by: Rolf Smeds <rolf@vaadin.com>
Solves:
#4782
#76 (sort of)
Changes: